From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: "Hennerich, Michael" <Michael.Hennerich@analog.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
Subject: Re: RFC: Rename iio_{allocate,free}_device to iio_device_{alloc,free}
Date: Tue, 22 Nov 2011 21:01:45 +0000 [thread overview]
Message-ID: <4ECC0DB9.9040401@kernel.org> (raw)
In-Reply-To: <4ECB9D6F.4070303@metafoo.de>
On 11/22/2011 01:02 PM, Lars-Peter Clausen wrote:
> Currently we have two pairs of functions which respectively are used to
> allocate/register and unregister/free a iio devices. The first pair is
> iio_allocate_device, iio_device_register and the second pair is
> iio_device_unregister, iio_free_device. So what can be seen is, that there
> is a bit of inconsistency here as to where to put the "device" in the
> function name.
>
> So in order to streamline the API I propose to rename iio_free_device to
> iio_device_free and iio_allocate_device to iio_device_alloc (alloc instead
> of allocate to be more in sync with other in kernel APIs e.g.
> platform_device_alloc).
>
> If nobody sees any problems or has any objections I'll send a patch.
Other than the allocate->alloc change I've already done the equivalent
for the outofstaging tree (having noted the same thing whilst cleaning
that up!). The alloc change makes sense so I'll drive it it there as
well at some point. Will obviously have to update the namespace move
patches but that's fine. I can't do those namespace patches until
staging-next gets updated anyway so can easily make them dependent
on what you do.
Jonathan
>
> - Lars
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-11-22 21:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 13:02 RFC: Rename iio_{allocate,free}_device to iio_device_{alloc,free} Lars-Peter Clausen
2011-11-22 21:01 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECC0DB9.9040401@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=manuel.stahl@iis.fraunhofer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).