* RFC: Rename iio_{allocate,free}_device to iio_device_{alloc,free}
@ 2011-11-22 13:02 Lars-Peter Clausen
2011-11-22 21:01 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2011-11-22 13:02 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hennerich, Michael, linux-iio@vger.kernel.org, Manuel Stahl
Currently we have two pairs of functions which respectively are used to
allocate/register and unregister/free a iio devices. The first pair is
iio_allocate_device, iio_device_register and the second pair is
iio_device_unregister, iio_free_device. So what can be seen is, that there
is a bit of inconsistency here as to where to put the "device" in the
function name.
So in order to streamline the API I propose to rename iio_free_device to
iio_device_free and iio_allocate_device to iio_device_alloc (alloc instead
of allocate to be more in sync with other in kernel APIs e.g.
platform_device_alloc).
If nobody sees any problems or has any objections I'll send a patch.
- Lars
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: RFC: Rename iio_{allocate,free}_device to iio_device_{alloc,free}
2011-11-22 13:02 RFC: Rename iio_{allocate,free}_device to iio_device_{alloc,free} Lars-Peter Clausen
@ 2011-11-22 21:01 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2011-11-22 21:01 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Hennerich, Michael, linux-iio@vger.kernel.org, Manuel Stahl
On 11/22/2011 01:02 PM, Lars-Peter Clausen wrote:
> Currently we have two pairs of functions which respectively are used to
> allocate/register and unregister/free a iio devices. The first pair is
> iio_allocate_device, iio_device_register and the second pair is
> iio_device_unregister, iio_free_device. So what can be seen is, that there
> is a bit of inconsistency here as to where to put the "device" in the
> function name.
>
> So in order to streamline the API I propose to rename iio_free_device to
> iio_device_free and iio_allocate_device to iio_device_alloc (alloc instead
> of allocate to be more in sync with other in kernel APIs e.g.
> platform_device_alloc).
>
> If nobody sees any problems or has any objections I'll send a patch.
Other than the allocate->alloc change I've already done the equivalent
for the outofstaging tree (having noted the same thing whilst cleaning
that up!). The alloc change makes sense so I'll drive it it there as
well at some point. Will obviously have to update the namespace move
patches but that's fine. I can't do those namespace patches until
staging-next gets updated anyway so can easily make them dependent
on what you do.
Jonathan
>
> - Lars
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-22 21:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-22 13:02 RFC: Rename iio_{allocate,free}_device to iio_device_{alloc,free} Lars-Peter Clausen
2011-11-22 21:01 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).