linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
	Michael Hennerich <michael.hennerich@analog.com>,
	linux-iio@vger.kernel.org,
	device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH v2 1/6] staging:iio: Update iio_event_interface documentation
Date: Mon, 19 Dec 2011 20:55:31 +0000	[thread overview]
Message-ID: <4EEFA4C3.4030607@kernel.org> (raw)
In-Reply-To: <1324290580-17511-1-git-send-email-lars@metafoo.de>

On 12/19/2011 10:29 AM, Lars-Peter Clausen wrote:
> The documentation for the iio_event_interface does not match the actual struct
> anymore. This patch removes the documentation for non-existing fields and adds
> documentation for missing fields.
> 
Thanks for cleaning that up.  We could add that the dev_attr_list is for
internal management only but I guess that easily established from
how it is use...
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
>  drivers/staging/iio/industrialio-core.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
> index 2eef85f..23dd624 100644
> --- a/drivers/staging/iio/industrialio-core.c
> +++ b/drivers/staging/iio/industrialio-core.c
> @@ -112,13 +112,14 @@ struct iio_detected_event_list {
>  
>  /**
>   * struct iio_event_interface - chrdev interface for an event line
> - * @dev:		device assocated with event interface
>   * @wait:		wait queue to allow blocking reads of events
>   * @event_list_lock:	mutex to protect the list of detected events
>   * @det_events:		list of detected events
>   * @max_events:		maximum number of events before new ones are dropped
>   * @current_events:	number of events in detected list
> + * @dev_attr_list:	list of event interface sysfs attribute
>   * @flags:		file operations related flags including busy flag.
> + * @group:		event interface sysfs attribute group
>   */
>  struct iio_event_interface {
>  	wait_queue_head_t			wait;

  parent reply	other threads:[~2011-12-19 20:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-19 10:29 [PATCH v2 1/6] staging:iio: Update iio_event_interface documentation Lars-Peter Clausen
2011-12-19 10:29 ` [PATCH v2 6/6] staging:iio:events: Use non-atmoic bitops Lars-Peter Clausen
2011-12-19 20:59   ` Jonathan Cameron
2012-01-29 10:49     ` Jonathan Cameron
2011-12-19 20:55 ` Jonathan Cameron [this message]
2011-12-19 21:28   ` [PATCH v2 1/6] staging:iio: Update iio_event_interface documentation Lars-Peter Clausen
     [not found] ` <1324290580-17511-2-git-send-email-lars@metafoo.de>
2011-12-19 20:56   ` [PATCH v2 2/6] staging:iio: Factor out event handling into its own file Jonathan Cameron
     [not found] ` <1324290580-17511-3-git-send-email-lars@metafoo.de>
2011-12-19 20:56   ` [PATCH v2 3/6] staging:iio:events: Use kfifo for event queue Jonathan Cameron
     [not found] ` <1324290580-17511-4-git-send-email-lars@metafoo.de>
2011-12-19 20:57   ` [PATCH v2 4/6] staging:iio:events: Use waitqueue lock to protect " Jonathan Cameron
2011-12-19 21:28     ` Lars-Peter Clausen
2012-01-29 18:18   ` Jonathan Cameron
2012-01-31 17:26     ` Lars-Peter Clausen
2012-01-31 20:58       ` Jonathan Cameron
  -- strict thread matches above, loose matches on Subject: below --
2012-02-01 18:45 [PATCH v2 0/6] staging:iio: Event handling updates Lars-Peter Clausen
2012-02-01 18:45 ` [PATCH v2 1/6] staging:iio: Update iio_event_interface documentation Lars-Peter Clausen
2012-02-01 21:17 [PATCH v2 0/6] staging:iio: Event handling updates Lars-Peter Clausen
2012-02-01 21:17 ` [PATCH v2 1/6] staging:iio: Update iio_event_interface documentation Lars-Peter Clausen
2012-02-09 18:12   ` Greg Kroah-Hartman
2012-02-09 19:06     ` Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EEFA4C3.4030607@kernel.org \
    --to=jic23@kernel.org \
    --cc=device-drivers-devel@blackfin.uclinux.org \
    --cc=drivers@analog.com \
    --cc=jic23@cam.ac.uk \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).