From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4EEFA4C3.4030607@kernel.org> Date: Mon, 19 Dec 2011 20:55:31 +0000 From: Jonathan Cameron MIME-Version: 1.0 To: Lars-Peter Clausen CC: Jonathan Cameron , Michael Hennerich , linux-iio@vger.kernel.org, device-drivers-devel@blackfin.uclinux.org, drivers@analog.com Subject: Re: [PATCH v2 1/6] staging:iio: Update iio_event_interface documentation References: <1324290580-17511-1-git-send-email-lars@metafoo.de> In-Reply-To: <1324290580-17511-1-git-send-email-lars@metafoo.de> Content-Type: text/plain; charset=ISO-8859-1 List-ID: On 12/19/2011 10:29 AM, Lars-Peter Clausen wrote: > The documentation for the iio_event_interface does not match the actual struct > anymore. This patch removes the documentation for non-existing fields and adds > documentation for missing fields. > Thanks for cleaning that up. We could add that the dev_attr_list is for internal management only but I guess that easily established from how it is use... > Signed-off-by: Lars-Peter Clausen Acked-by: Jonathan Cameron > --- > drivers/staging/iio/industrialio-core.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c > index 2eef85f..23dd624 100644 > --- a/drivers/staging/iio/industrialio-core.c > +++ b/drivers/staging/iio/industrialio-core.c > @@ -112,13 +112,14 @@ struct iio_detected_event_list { > > /** > * struct iio_event_interface - chrdev interface for an event line > - * @dev: device assocated with event interface > * @wait: wait queue to allow blocking reads of events > * @event_list_lock: mutex to protect the list of detected events > * @det_events: list of detected events > * @max_events: maximum number of events before new ones are dropped > * @current_events: number of events in detected list > + * @dev_attr_list: list of event interface sysfs attribute > * @flags: file operations related flags including busy flag. > + * @group: event interface sysfs attribute group > */ > struct iio_event_interface { > wait_queue_head_t wait;