linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org,
	Wolfgang Denk <wd@denx.de>, Stefano Babic <sbabic@denx.de>,
	Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH 1/2] [RFC] Add per-channel oversampling count
Date: Fri, 10 Feb 2012 11:02:35 +0000	[thread overview]
Message-ID: <4F34F94B.3070709@cam.ac.uk> (raw)
In-Reply-To: <201202101144.51719.marek.vasut@gmail.com>

On 2/10/2012 10:44 AM, Marek Vasut wrote:
>> On 2/10/2012 5:52 AM, Marek Vasut wrote:
>>> This allows each channel to configure it's oversampling count.
>> Fine, but please also add documention in
>> staging/iio/Documentation/sysfs-bus-iio
> Understood. Is doing it this way OK with you?
Yup. Though as the other email states, it is going to be 'interesting' 
handling this through the demux
that sends the right data to individual consumer drivers.
>
> M
>
>>> Signed-off-by: Marek Vasut<marek.vasut@gmail.com>
>>> Cc: Wolfgang Denk<wd@denx.de>
>>> Cc: Stefano Babic<sbabic@denx.de>
>>> Cc: Fabio Estevam<festevam@gmail.com>
>>> ---
>>>
>>>    drivers/staging/iio/iio.h               |    5 +++++
>>>    drivers/staging/iio/industrialio-core.c |    1 +
>>>    2 files changed, 6 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/staging/iio/iio.h b/drivers/staging/iio/iio.h
>>> index b3a1740..0b626ae 100644
>>> --- a/drivers/staging/iio/iio.h
>>> +++ b/drivers/staging/iio/iio.h
>>> @@ -36,6 +36,7 @@ enum iio_chan_info_enum {
>>>
>>>    	IIO_CHAN_INFO_QUADRATURE_CORRECTION_RAW,
>>>    	IIO_CHAN_INFO_AVERAGE_RAW,
>>>    	IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY,
>>>
>>> +	IIO_CHAN_INFO_OVERSAMPLE_COUNT,
>>>
>>>    };
>>>
>>>    #define IIO_CHAN_INFO_SHARED_BIT(type) BIT(type*2)
>>>
>>> @@ -81,6 +82,10 @@ enum iio_chan_info_enum {
>>>
>>>    #define IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY_SEPARATE_BIT \
>>>
>>>    	IIO_CHAN_INFO_SEPARATE_BIT(			       \
>>>    	
>>>    		IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY)
>>>
>>> +#define IIO_CHAN_INFO_OVERSAMPLE_COUNT_SEPARATE_BIT		\
>>> +	IIO_CHAN_INFO_SEPARATE_BIT(IIO_CHAN_INFO_OVERSAMPLE_COUNT)
>>> +#define IIO_CHAN_INFO_OVERSAMPLE_COUNT_SHARED_BIT		\
>>> +	IIO_CHAN_INFO_SHARED_BIT(IIO_CHAN_INFO_OVERSAMPLE_COUNT)
>>>
>>>    enum iio_endian {
>>>
>>>    	IIO_CPU,
>>>
>>> diff --git a/drivers/staging/iio/industrialio-core.c
>>> b/drivers/staging/iio/industrialio-core.c index 9c41c83..05b6fdd 100644
>>> --- a/drivers/staging/iio/industrialio-core.c
>>> +++ b/drivers/staging/iio/industrialio-core.c
>>> @@ -87,6 +87,7 @@ static const char * const iio_chan_info_postfix[] = {
>>>
>>>    	[IIO_CHAN_INFO_AVERAGE_RAW] = "mean_raw",
>>>    	[IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY]
>>>    	= "filter_low_pass_3db_frequency",
>>>
>>> +	[IIO_CHAN_INFO_OVERSAMPLE_COUNT] = "oversample_count",
>>>
>>>    };
>>>
>>>    const struct iio_chan_spec


  reply	other threads:[~2012-02-10 11:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10  5:52 [PATCH 1/2] [RFC] Add per-channel oversampling count Marek Vasut
2012-02-10  5:52 ` [PATCH 2/2] [RFC] Basic support for MX28 LRADC IIO interface Marek Vasut
2012-02-10 11:00   ` Jonathan Cameron
2012-02-10 11:17     ` Marek Vasut
2012-02-10 11:26       ` Jonathan Cameron
2012-02-10  9:51 ` [PATCH 1/2] [RFC] Add per-channel oversampling count Jonathan Cameron
2012-02-10 10:44   ` Marek Vasut
2012-02-10 11:02     ` Jonathan Cameron [this message]
2012-02-10 11:19       ` Marek Vasut
2012-02-10 11:31         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F34F94B.3070709@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=festevam@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=marek.vasut@gmail.com \
    --cc=sbabic@denx.de \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).