From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ppsw-51.csi.cam.ac.uk ([131.111.8.151]:54525 "EHLO ppsw-51.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751849Ab2DKLx6 (ORCPT ); Wed, 11 Apr 2012 07:53:58 -0400 Message-ID: <4F8570CF.1010709@cam.ac.uk> Date: Wed, 11 Apr 2012 12:53:51 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Lars-Peter Clausen CC: Jonathan Cameron , linux-iio@vger.kernel.org, device-drivers-devel@blackfin.uclinux.org Subject: Re: [PATCH 00/14] IIO: Kill off IIO_CHAN macro. References: <1334089310-22576-1-git-send-email-jic23@kernel.org> <4F856945.9040704@metafoo.de> <4F85690D.1050605@cam.ac.uk> <4F85712E.9010301@metafoo.de> In-Reply-To: <4F85712E.9010301@metafoo.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 4/11/2012 12:55 PM, Lars-Peter Clausen wrote: > On 04/11/2012 01:20 PM, Jonathan Cameron wrote: >> On 4/11/2012 12:21 PM, Lars-Peter Clausen wrote: >>> On 04/10/2012 10:21 PM, Jonathan Cameron wrote: >>>> This kills off the remaing users and gets rid of it! >>>> >>>> Please can people sanity check I haven't messed up the >>>> removal in their drivers (and anyone elses if they are >>>> bored enough!) >>> I wrote a small set of cocci scripts which automate the removal and detected >>> some small issues. If you are interested in the scripts I've uploaded them >>> at http://metafoo.de/kill_iio_chan.tar.bz2 >>> >>> The cocci pretty printer doesn't cope very well with unwinding a macro, so >>> I've added some extra sed expressions to cleanup the result. >>> >>> >> Don't suppose you fancy updating those to do the processed and unprocessed >> stuff >> you suggested? >> > These are just for the IIO_CHAN() macro removal, but I can try to come up > with some that also do the conversion to explicit value attributes. Gah, too many balls in the air! Thanks for looking at these. Will update sometime soonish.