linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: gregkh@linuxfoundation.org, grant.likely@secretlab.ca,
	rob.herring@calxeda.com, jbrenner@taosinc.com, rklein@nvidia.com,
	max@stro.at, linux-iio@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH V2 2/2] staging: Documentation: add proximity_sampling_period as sysfs details
Date: Thu, 12 Apr 2012 10:37:47 +0100	[thread overview]
Message-ID: <4F86A26B.1090209@cam.ac.uk> (raw)
In-Reply-To: <1334214492-23044-3-git-send-email-ldewangan@nvidia.com>

On 4/12/2012 8:08 AM, Laxman Dewangan wrote:
> Add the sysfs proximity_sampling_period for sampling period of
> proximity sensing.
>
> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
> ---
>   .../staging/iio/Documentation/sysfs-bus-iio-light  |    7 +++++++
>   1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/iio/Documentation/sysfs-bus-iio-light b/drivers/staging/iio/Documentation/sysfs-bus-iio-light
> index edbf470..9d6108b 100644
> --- a/drivers/staging/iio/Documentation/sysfs-bus-iio-light
> +++ b/drivers/staging/iio/Documentation/sysfs-bus-iio-light
> @@ -83,3 +83,10 @@ Description:
>   		Hardware or software applied calibration scale factor assumed
>   		to account for attenuation due to industrial design (glass
>   		filters or aperture holes).
> +
> +What:		/sys/bus/iio/devices/device[n]/proximity_sampling_period
> +KernelVersion:	3.5
> +Contact:	linux-iio@vger.kernel.org
> +Description:
> +		Hardware dependent mode for proximity sensor device to set/get
> +		the sampling rate of proximity sensing and conversion.
Ah, that explains what it is.  Sorry, use 
in_proximitiy0_sampling_frequency to provide equivalent
control please.  Might be a pain here, but this interface will just 
provide the same info as the existing
one in a different form.  Note that sampling_frequency is documented as 
a general one, but can
be extended to individual channels.

Actually add it to the iio-core as an element in the info_mask as I 
doubt this will be the last time
we see this control. This will need to be a precursor patch to the 
driver obviously.

IIO_CHAN_INFO_SAMP_FREQ and the relevant shared and separate macros need 
to go in
iio.h + the text entry in industrialio-core.c

If you like I can do this but it'll be quicker if you do :)

  reply	other threads:[~2012-04-12  9:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-12  7:08 [PATCH V2 0/2] staging: iio: add isl29028 driver Laxman Dewangan
2012-04-12  7:08 ` [PATCH V2 1/2] staging: iio: add driver for isl29028 Laxman Dewangan
2012-04-12  7:35   ` Dan Carpenter
2012-04-12  9:32   ` Jonathan Cameron
2012-04-12  7:08 ` [PATCH V2 2/2] staging: Documentation: add proximity_sampling_period as sysfs details Laxman Dewangan
2012-04-12  9:37   ` Jonathan Cameron [this message]
2012-04-12  9:48     ` Laxman Dewangan
2012-04-12 10:01       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F86A26B.1090209@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbrenner@taosinc.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max@stro.at \
    --cc=rklein@nvidia.com \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).