From: Laxman Dewangan <ldewangan@nvidia.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"jbrenner@taosinc.com" <jbrenner@taosinc.com>,
Rhyland Klein <rklein@nvidia.com>, "max@stro.at" <max@stro.at>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH V3 1/2] staging: iio: add channel info for sampling frequency
Date: Thu, 12 Apr 2012 18:39:01 +0530 [thread overview]
Message-ID: <4F86D3ED.4020301@nvidia.com> (raw)
In-Reply-To: <4F86D55F.2030808@cam.ac.uk>
On Thursday 12 April 2012 06:45 PM, Jonathan Cameron wrote:
> On 4/12/2012 1:38 PM, Laxman Dewangan wrote:
>> Adding channel info IIO_CHAN_INFO_SAMP_FREQ to select
>> different sampling frequency per channel wise.
>>
>> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
>> ---
>> As per discussion on previous patch, adding channel info
>> for selecting sampling freqeuncy.
> To match with the existing devices can we not use the abrieviation
> for the attribute naming.
>
Sorry..I did not get it completely.
Is it like we should have IIO_CHAN_INFO_SAMPLING_FREQUENCY in place of
IIO_CHAN_INFO_SAMP_FREQ?
>> @@ -90,6 +90,7 @@ static const char * const iio_chan_info_postfix[] = {
>> [IIO_CHAN_INFO_AVERAGE_RAW] = "mean_raw",
>> [IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY]
>> = "filter_low_pass_3db_frequency",
>> + [IIO_CHAN_INFO_SAMP_FREQ] = "samp_freq",
> "sampling_frequency"
and then change here as "sampling_frequency"?
next prev parent reply other threads:[~2012-04-12 13:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 12:38 [PATCH V3 0/2] staging: iio: add isl29028 driver Laxman Dewangan
2012-04-12 12:38 ` [PATCH V3 1/2] staging: iio: add channel info for sampling frequency Laxman Dewangan
2012-04-12 13:15 ` Jonathan Cameron
2012-04-12 13:09 ` Laxman Dewangan [this message]
2012-04-12 13:21 ` Jonathan Cameron
2012-04-12 12:38 ` [PATCH V3 2/2] staging: iio: add driver for isl29028 Laxman Dewangan
2012-04-12 13:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F86D3ED.4020301@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jbrenner@taosinc.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@stro.at \
--cc=rklein@nvidia.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).