Re: [PATCH] staging: iio: add lsm303dlh magnetometer driver

[Jonathan Cameron <jic23@cam.ac.uk>]

On 4/17/2012 7:47 AM, Srinidhi Kasagar wrote:
> On Tue, Apr 17, 2012 at 08:29:36 +0200, Shubhrajyoti Datta wrote:
>> Hi Srinidhi,
>>
>> On Mon, Apr 9, 2012 at 5:04 PM, Srinidhi KASAGAR
>> <srinidhi.kasagar@stericsson.com>  wrote:
>>> Add support for lsm303dlh magnetometer device.
>>>
>>> Signed-off-by: srinidhi kasagar<srinidhi.kasagar@stericsson.com>
>>> Acked-by: Linus Walleij<linus.walleij@linaro.org>
>>> ---
> [...]
>
>>> diff --git a/drivers/staging/iio/magnetometer/lsm303dlh.c b/drivers/staging/iio/magnetometer/lsm303dlh.c
>>> new file mode 100644
>>> index 0000000..4b23083
>>> --- /dev/null
>>> +++ b/drivers/staging/iio/magnetometer/lsm303dlh.c
>>> @@ -0,0 +1,803 @@
>>> +/*
>>> + * Copyright (C) ST-Ericsson SA 2012
>>> + * License Terms: GNU General Public License, version 2
>>> + *
>>> + * This code is mostly based on hmc5843 driver
>>> + *
>> How different is it from the hmc5843 driver Can we add support in the
>> hmc driver itself?
> The device differs from hmc in many ways, for example, it has a higher
> range upto +/- 8.1 gauss, and has separate gain controls for X/Y and Z.
> Since both are different devices, with different capabilities, i don't
> think we can merge them together.
>
> The lsm303dlh datahsheet is available here
> http://www.st.com/internet/com/TECHNICAL_RESOURCES/TECHNICAL_LITERATURE/DATASHEET/CD00260288.pdf
>
> However this has been superseded with "lsm303dlhc" version, will add
> support to this version too later, though they are trivial..
> http://www.st.com/internet/com/TECHNICAL_RESOURCES/TECHNICAL_LITERATURE/DATASHEET/DM00027543.pdf
>
> srinidhi
Thanks for the clear references.  For two superficially similar devices 
there are an
awful lot of differences in the register set.   They could be merged, 
but my gut
feeling is that they will be easier to maintain as two separate drivers.

Jonathan