From: Jonathan Cameron <jic23@cam.ac.uk>
To: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"device-drivers-devel@blackfin.uclinux.org"
<device-drivers-devel@blackfin.uclinux.org>
Subject: Re: necessity of manual reset attribute in drivers?
Date: Tue, 24 Apr 2012 09:25:07 +0100 [thread overview]
Message-ID: <4F966363.7080203@cam.ac.uk> (raw)
In-Reply-To: <544AC56F16B56944AEC3BD4E3D5917714E793C210F@LIMKCMBX1.ad.analog.com>
On 4/24/2012 8:52 AM, Hennerich, Michael wrote:
> Jonathan Cameron wrote on 2012-04-22:
>> Hi All,
>>
>> I vaguely recall asking this in response to certain drivers over the
>> years, but what is the usecase for userspace 'resetting' a device via
>> a reset attribute? It's reasonably common in the drivers but not
>> (as I've kept it out) in the abi docs.
>>
>> It is common in some of Analog's inertial sensor drivers but I think
>> turns up in various other places.
> Ideally we shouldn't have such an attribute.
> Error checking and handling should be all done in the drivers, if possible.
> I don't remember exactly why it went into one of the original inertial sensor drivers.
> But I think it went there to provide error correction, in case plausibility/error checking
> of the delivered data failed.
> I also suspect it then got copied over and over again.
That's what I suspected had happened. Shall we aim to kill it off in
these drivers
before they move out of staging? I'm always happy to delete code if no
one else
gets to them first ;)
prev parent reply other threads:[~2012-04-24 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-22 17:24 IIO: necessity of manual reset attribute in drivers? Jonathan Cameron
2012-04-24 7:52 ` Hennerich, Michael
2012-04-24 8:25 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F966363.7080203@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=Michael.Hennerich@analog.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).