From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] staging:iio: Streamline API function naming
Date: Wed, 25 Apr 2012 19:34:39 +0200 [thread overview]
Message-ID: <4F9835AF.4050206@metafoo.de> (raw)
In-Reply-To: <4F9810CA.4070306@cam.ac.uk>
On 04/25/2012 04:57 PM, Jonathan Cameron wrote:
> On 4/25/2012 1:18 PM, Lars-Peter Clausen wrote:
>> Currently we use two different naming schemes in the IIO API,
>> iio_verb_object
>> and iio_object_verb. E.g iio_device_register and iio_allocate_device.
>> This
>> patches renames instances of the later to the former. The patch also
>> renames allocate to
>> alloc as this seems to be the preferred form throughout the kernel.
>>
>> In particular the following renames are performed by the patch:
>> iio_put_device -> iio_device_put
>> iio_allocate_device -> iio_device_alloc
>> iio_free_device -> iio_device_free
>> iio_get_trigger -> iio_trigger_get
>> iio_put_trigger -> iio_trigger_put
>> iio_allocate_trigger -> iio_trigger_alloc
>> iio_free_trigger -> iio_trigger_free
>>
>> The conversion was done with the following coccinelle patch with
>> manual fixes to
>> comments and documentation.
> I'm entirely in favour of this. Actually did half of them in the
> original attempt to move out of staging but never pulled back into
> the main tree!
>
> Assuming Greg merges the series that I just sent out to move the core
> out of staging, could you regenerate against the files in their new
> locations?
>
Yes, sure. I think git may even be able to track the rename, so rebasing the
patch shouldn't be much of a problem.
- Lars
next prev parent reply other threads:[~2012-04-25 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 12:18 [PATCH] staging:iio: Streamline API function naming Lars-Peter Clausen
[not found] ` <4F9810CA.4070306@cam.ac.uk>
2012-04-25 17:34 ` Lars-Peter Clausen [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-25 19:07 Lars-Peter Clausen
2012-04-26 11:35 Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9835AF.4050206@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).