From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Peter Meerwald <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: add mcp4725 I2C DAC driver
Date: Mon, 30 Apr 2012 20:37:45 +0200 [thread overview]
Message-ID: <4F9EDBF9.5000806@metafoo.de> (raw)
In-Reply-To: <4F9EA43F.7000803@cam.ac.uk>
On 04/30/2012 04:39 PM, Jonathan Cameron wrote:
> On 4/30/2012 2:54 PM, Peter Meerwald wrote:
>> v2 (based on comments from Jonathan Cameron and Lars-Peter Clausen):
>> * did NOT switch to chan_spec yet
> I guess from this you are intending to? I guess whether we merge this as
> is depends
> on what timescale you are thinking of to make that change?
>> * rebase to staging-next tree, update iio header locations
>> * dropped dac.h #include, not needed
>> * strict_strtol() -> kstrtol()
>> * call iio_device_unregister() in remove()
>> * everything in one patch
> If you want to send it on to Greg KH now and Lars-Peter is happy, then
> that's fine by me.
I don't think it's a good idea to introduce new non chan_spec drivers.
Especially for simple drivers like this one where it is relatively easy to add
chan_spec support. So no ack from my side, but that's not necessarily a blocker
for the patch.
>> Signed-off-by: Peter Meerwald<pmeerw@pmeerw.net>
> Acked-by: Jonathan Cameron <jic23@kernel.org>
next prev parent reply other threads:[~2012-04-30 18:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 17:13 [PATCH 1/2] iio: add Kconfig option and Makefile entry for mcp4725 I2C DAC driver Peter Meerwald
2012-04-29 17:13 ` [PATCH 2/2] iio: add " Peter Meerwald
2012-04-30 9:43 ` Jonathan Cameron
2012-04-30 10:18 ` Peter Meerwald
2012-04-30 10:27 ` Jonathan Cameron
2012-04-30 13:54 ` [PATCH] " Peter Meerwald
2012-04-30 14:39 ` Jonathan Cameron
2012-04-30 18:37 ` Lars-Peter Clausen [this message]
2012-04-30 10:24 ` [PATCH 2/2] " Lars-Peter Clausen
2012-04-30 14:12 ` [PATCH 1/2] iio: replace strict_strtol() with kstrtol() in max517 driver Peter Meerwald
2012-04-30 14:12 ` [PATCH 2/2] iio: call iio_device_unregister() in max517_remove() Peter Meerwald
2012-04-30 14:41 ` Jonathan Cameron
2012-04-30 14:41 ` [PATCH 1/2] iio: replace strict_strtol() with kstrtol() in max517 driver Jonathan Cameron
2012-04-30 9:20 ` [PATCH 1/2] iio: add Kconfig option and Makefile entry for mcp4725 I2C DAC driver Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2012-06-06 21:40 [PATCH] iio: add " Peter Meerwald
2012-06-07 7:36 ` Jonathan Cameron
2012-06-07 8:30 Peter Meerwald
2012-06-07 16:07 ` Jonathan Cameron
2012-06-08 7:12 ` Peter Meerwald
2012-06-08 7:34 ` Jonathan Cameron
2012-06-08 7:07 Peter Meerwald
2012-06-08 7:36 ` Jonathan Cameron
2012-06-08 16:06 Peter Meerwald
2012-06-12 21:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9EDBF9.5000806@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).