From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:41808 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757284Ab2EJIJo (ORCPT ); Thu, 10 May 2012 04:09:44 -0400 Message-ID: <4FAB77C7.8080507@kernel.org> Date: Thu, 10 May 2012 09:09:43 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: michael.hennerich@analog.com CC: linux-iio@vger.kernel.org, device-drivers-devel@blackfin.uclinux.org Subject: Re: [PATCH 2/3] iio: core: introduce IIO_CHAN_INFO_HARDWAREGAIN References: <1336559774-21136-1-git-send-email-michael.hennerich@analog.com> <1336559774-21136-2-git-send-email-michael.hennerich@analog.com> In-Reply-To: <1336559774-21136-2-git-send-email-michael.hennerich@analog.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 5/9/2012 11:36 AM, michael.hennerich@analog.com wrote: > From: Michael Hennerich > > Signed-off-by: Michael Hennerich Acked-by: Jonathan Cameron > --- > Documentation/ABI/testing/sysfs-bus-iio | 7 +++++++ > drivers/iio/industrialio-core.c | 1 + > include/linux/iio/iio.h | 5 +++++ > 3 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > index ccd8c84..cfedf63 100644 > --- a/Documentation/ABI/testing/sysfs-bus-iio > +++ b/Documentation/ABI/testing/sysfs-bus-iio > @@ -282,6 +282,13 @@ Description: > If a discrete set of scale values are available, they > are listed in this attribute. > > +What /sys/bus/iio/devices/iio:deviceX/out_voltageY_hardwaregain > +KernelVersion: 2.6.35 > +Contact: linux-iio@vger.kernel.org > +Description: > + Hardware applied gain factor. If shared across all channels, > + _hardwaregain is used. > + > What: /sys/.../in_accel_filter_low_pass_3db_frequency > What: /sys/.../in_magn_filter_low_pass_3db_frequency > What: /sys/.../in_anglvel_filter_low_pass_3db_frequency > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c > index e799d35..874fb70 100644 > --- a/drivers/iio/industrialio-core.c > +++ b/drivers/iio/industrialio-core.c > @@ -91,6 +91,7 @@ static const char * const iio_chan_info_postfix[] = { > [IIO_CHAN_INFO_SAMP_FREQ] = "sampling_frequency", > [IIO_CHAN_INFO_FREQUENCY] = "frequency", > [IIO_CHAN_INFO_PHASE] = "phase", > + [IIO_CHAN_INFO_HARDWAREGAIN] = "hardwaregain", > }; > > const struct iio_chan_spec > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h > index 6fdbdb8..897c6b0 100644 > --- a/include/linux/iio/iio.h > +++ b/include/linux/iio/iio.h > @@ -34,6 +34,7 @@ enum iio_chan_info_enum { > IIO_CHAN_INFO_SAMP_FREQ, > IIO_CHAN_INFO_FREQUENCY, > IIO_CHAN_INFO_PHASE, > + IIO_CHAN_INFO_HARDWAREGAIN, > }; > > #define IIO_CHAN_INFO_SHARED_BIT(type) BIT(type*2) > @@ -95,6 +96,10 @@ enum iio_chan_info_enum { > IIO_CHAN_INFO_SEPARATE_BIT(IIO_CHAN_INFO_PHASE) > #define IIO_CHAN_INFO_PHASE_SHARED_BIT \ > IIO_CHAN_INFO_SHARED_BIT(IIO_CHAN_INFO_PHASE) > +#define IIO_CHAN_INFO_HARDWAREGAIN_SEPARATE_BIT \ > + IIO_CHAN_INFO_SEPARATE_BIT(IIO_CHAN_INFO_HARDWAREGAIN) > +#define IIO_CHAN_INFO_HARDWAREGAIN_SHARED_BIT \ > + IIO_CHAN_INFO_SHARED_BIT(IIO_CHAN_INFO_HARDWAREGAIN) > > enum iio_endian { > IIO_CPU,