Re: [PATCH 5/8] iio: add check for measurement configuration value passed to hmc5843

[Jonathan Cameron <jic23@kernel.org>]

On 5/8/2012 11:20 PM, Peter Meerwald wrote:
> From: Peter Meerwald<p.meerwald@bct-electronic.com>
>
I'm not keen on the underlying code, but this is still worth having!
Something string based at least, or that played well with runtime
power management would be nice. Ah well, can't have everything :(
> Signed-off-by: Peter Meerwald<pmeerw@pmeerw.net>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
>   drivers/staging/iio/magnetometer/hmc5843.c |    7 ++++++-
>   1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c
> index 6888e04..57ab4fb 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843.c
> @@ -281,9 +281,14 @@ static ssize_t hmc5843_set_measurement_configuration(struct device *dev,
>   	struct i2c_client *client = to_i2c_client(indio_dev->dev.parent);
>   	struct hmc5843_data *data = iio_priv(indio_dev);
>   	unsigned long meas_conf = 0;
> -	int error = kstrtoul(buf, 10,&meas_conf);
> +	int error;
> +
> +	error = kstrtoul(buf, 10,&meas_conf);
>   	if (error)
>   		return error;
> +	if (meas_conf>= HMC5843_MEAS_CONF_NOT_USED)
> +		return -EINVAL;
> +
>   	mutex_lock(&data->lock);
>
>   	dev_dbg(dev, "set mode to %lu\n", meas_conf);