From: Jonathan Cameron <jic23@cam.ac.uk>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: Remove unused iio_device_put()
Date: Fri, 11 May 2012 13:28:03 +0100 [thread overview]
Message-ID: <4FAD05D3.2020709@cam.ac.uk> (raw)
In-Reply-To: <1336736816-15678-1-git-send-email-lars@metafoo.de>
On 5/11/2012 12:46 PM, Lars-Peter Clausen wrote:
> This function is currently unused and we do not have a matching iio_device_get()
> function either, so just remove it.
>
> Signed-off-by: Lars-Peter Clausen<lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> include/linux/iio/iio.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index 6fdbdb8..eff2a39 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -412,16 +412,6 @@ int iio_push_event(struct iio_dev *indio_dev, u64 ev_code, s64 timestamp);
>
> extern struct bus_type iio_bus_type;
>
> -/**
> - * iio_device_put() - reference counted deallocation of struct device
> - * @dev: the iio_device containing the device
> - **/
> -static inline void iio_device_put(struct iio_dev *indio_dev)
> -{
> - if (indio_dev)
> - put_device(&indio_dev->dev);
> -};
> -
> /* Can we make this smaller? */
> #define IIO_ALIGN L1_CACHE_BYTES
> /**
prev parent reply other threads:[~2012-05-11 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 11:46 [PATCH 1/2] iio: Remove unused iio_device_put() Lars-Peter Clausen
2012-05-11 11:46 ` [PATCH 2/2] iio: Fix potential use after free Lars-Peter Clausen
2012-05-11 12:28 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAD05D3.2020709@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).