Re: trigger removal problem.

[Jonathan Cameron <jic23@kernel.org>]

On 05/11/2012 06:45 PM, Ge Gao wrote:
> I found that if I write "NULL" to the "current_trigger", it will not be
> able to be removed. However, if I write a valid trigger name, such as the
> one in my driver code, it can be removed. Looks strange. But solve the
> problem anyway.
> I actually want to submit my driver code to you. However, it is pretty
> big(it supports all invensense sensors, which are similar but some
> differences still). Is that possible I package the code and send it
> directly?
Much better to do it as an inline patch in an email if you can.

Attachements are just about alright if you really can't do that.
Just how many lines of code are we talking?


> Thanks for your help.
> 
> Ge
> 
> 
> -----Original Message-----
> From: Jonathan Cameron [mailto:jic23@cam.ac.uk]
> Sent: Friday, May 11, 2012 12:40 AM
> To: Ge Gao
> Cc: linux-iio@vger.kernel.org
> Subject: Re: trigger removal problem.
> 
> On 5/11/2012 12:53 AM, Ge Gao wrote:
>> Dear all,
>>
>>                  I am building my IIO driver as a module and will
>> constantly need to use "insmod" and "rmmod" to install it and remove
>> it due to development. However, I found that if I write anything to
>> the "trigger/current_trigger", it will not be able to remove it. The
>> error code is (11). Even I write "null" to it, it will not be able to
>> be removed.
>> However, If I don't write anything to it, just insmod and rmmod, it
>> will be remove successfully. Any idea what could cause this problem? I
>> followed what is in the IIO subsystem driver to write my driver. I can
>> post it if anyone want to take a look.
> Hi Ge,
> 
> I'm afraid I won't be able to do any testing until at least tomorrow.
> There are a few things that could give more information though in the
> meantime:
> 
> * Could you try the above, but note down the reference counts that lsmod
> will give you for the various drivers at each step of the process. (before
> connecting the trigger, whilst it is connected and upon disconnecting).
> 
> * Is there anything left when you read 'current_trigger' after writing an
> invalid name to it?
> 
> *  Are you using an existing trigger or is it also part of you driver?
> 
> Having the source code when I dig futher into this would also be helpful.
> 
> Anyone else seen anything similar?  I haven't run any removal hammering
> tests for a month or so, so something might have slipped into the core...
> 
> Jonathan
>>
>>                  Thanks.
>>
>>
>>
>> Ge
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio"
>> in the body of a message to majordomo@vger.kernel.org More majordomo
>> info at  http://vger.kernel.org/majordomo-info.html