From: Lars-Peter Clausen <lars@metafoo.de>
To: Roland Stigge <stigge@antcom.de>
Cc: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/3] staging:iio:dac:max517: Convert to channel spec
Date: Sun, 13 May 2012 11:20:30 +0200 [thread overview]
Message-ID: <4FAF7CDE.8070507@metafoo.de> (raw)
In-Reply-To: <4FAF79AB.1080906@antcom.de>
On 05/13/2012 11:06 AM, Roland Stigge wrote:
> Hi,
>
> On 13/05/12 09:25, Lars-Peter Clausen wrote:
>>> I'm generally fine with the proposed changes and can ack it. However, we
>>> should provide a replacement for the old "1&2" attribute. It supports a
>>> certain hardware feature of this chip. No need to sacrifice it.
>>
>> I don't think it makes sense to keep it in it's current form. First of all this
>> isn't really covered by the IIO spec to have one attribute which changes two
>> (or more) output at once and secondly it is artificially limited to setting the
>> same value on both outputs, while the chip doesn't have this limitations and
>> you can set different values on both outputs at once.
>
> Please consider this as a special feature of the chip (setting the
> outputs timely at once), not a "limitation", since you can also set them
> individually.
>
What I meant was that it is not a limitation of the chip, but the driver only
allows limited use of that feature. You can only set the same value on both
outputs simultaneously, which I think has not so many practical use-cases.
You'd rather want to set two different values on output 1 and 2.
- Lars
next prev parent reply other threads:[~2012-05-13 9:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 17:04 [PATCH 1/3] staging:iio:dac: Remove unused dac.h includes Lars-Peter Clausen
2012-05-11 17:04 ` [PATCH 2/3] staging:iio:dac:max517: Convert to channel spec Lars-Peter Clausen
2012-05-12 18:51 ` Jonathan Cameron
2012-05-12 21:44 ` Roland Stigge
2012-05-13 7:25 ` Lars-Peter Clausen
2012-05-13 9:06 ` Roland Stigge
2012-05-13 9:20 ` Lars-Peter Clausen [this message]
2012-05-13 9:41 ` Roland Stigge
2012-05-13 15:03 ` Lars-Peter Clausen
2012-05-14 14:31 ` Lars-Peter Clausen
2012-05-14 14:39 ` Jonathan Cameron
2012-05-11 17:04 ` [PATCH 3/3] staging:iio:dac: Remove dac.h Lars-Peter Clausen
2012-05-12 18:52 ` Jonathan Cameron
2012-05-12 18:20 ` [PATCH 1/3] staging:iio:dac: Remove unused dac.h includes Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAF7CDE.8070507@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).