From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
linux-iio@vger.kernel.org, Roland Stigge <stigge@antcom.de>
Subject: Re: [PATCH 2/3] staging:iio:dac:max517: Convert to channel spec
Date: Mon, 14 May 2012 15:39:37 +0100 [thread overview]
Message-ID: <4FB11929.20705@kernel.org> (raw)
In-Reply-To: <4FB1175C.4020008@metafoo.de>
On 5/14/2012 3:31 PM, Lars-Peter Clausen wrote:
> On 05/12/2012 08:51 PM, Jonathan Cameron wrote:
>> [...]
>>> -static const struct iio_info max518_info = {
>>> - .attrs =&max518_attribute_group,
>>> - .driver_module = THIS_MODULE,
>>> +#define MAX517_CHANNEL(chan) { \
>>> + .type = IIO_VOLTAGE, \
>>> + .indexed = 1, \
>>> + .output = 1, \
>>> + .channel = (chan), \
>>> + .info_mask = IIO_CHAN_INFO_RAW_SEPARATE_BIT | \
>>> + IIO_CHAN_INFO_SCALE_SEPARATE_BIT, \
>> I suppose the scan_type acts as kind of documentation, but
>> it's not really relevant or necessary here... I'd scrap it.
>
> I'd like to keep it, because I think it will be used in the future. E.g. for
> buffer output, but also some other things might make use of it.
I'll let it go then...
>
>>> + .scan_type = IIO_ST('u', 8, 8, 0), \
>>> +}
>
next prev parent reply other threads:[~2012-05-14 14:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 17:04 [PATCH 1/3] staging:iio:dac: Remove unused dac.h includes Lars-Peter Clausen
2012-05-11 17:04 ` [PATCH 2/3] staging:iio:dac:max517: Convert to channel spec Lars-Peter Clausen
2012-05-12 18:51 ` Jonathan Cameron
2012-05-12 21:44 ` Roland Stigge
2012-05-13 7:25 ` Lars-Peter Clausen
2012-05-13 9:06 ` Roland Stigge
2012-05-13 9:20 ` Lars-Peter Clausen
2012-05-13 9:41 ` Roland Stigge
2012-05-13 15:03 ` Lars-Peter Clausen
2012-05-14 14:31 ` Lars-Peter Clausen
2012-05-14 14:39 ` Jonathan Cameron [this message]
2012-05-11 17:04 ` [PATCH 3/3] staging:iio:dac: Remove dac.h Lars-Peter Clausen
2012-05-12 18:52 ` Jonathan Cameron
2012-05-12 18:20 ` [PATCH 1/3] staging:iio:dac: Remove unused dac.h includes Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB11929.20705@kernel.org \
--to=jic23@kernel.org \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).