From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4FBB4A37.4090302@analog.com> Date: Tue, 22 May 2012 10:11:35 +0200 From: Michael Hennerich Reply-To: MIME-Version: 1.0 To: Jonathan Cameron CC: Jonathan Cameron , Johan Hovold , Rob Landley , Richard Purdie , Samuel Ortiz , Greg Kroah-Hartman , Florian Tobias Schandinat , Arnd Bergmann , Andrew Morton , Mark Brown , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-iio@vger.kernel.org" Subject: Re: [PATCH v4] iio: add LM3533 ambient-light-sensor driver References: <1337100396-29024-1-git-send-email-jhovold@gmail.com> <1337346461-31220-1-git-send-email-jhovold@gmail.com> <4FB75E57.9020003@kernel.org> <20120521095010.GD21033@localhost> <4FBA6F37.4000609@kernel.org> <4FBB4415.3090908@analog.com> <4FBB4526.5030506@cam.ac.uk> In-Reply-To: <4FBB4526.5030506@cam.ac.uk> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed List-ID: On 05/22/2012 09:49 AM, Jonathan Cameron wrote: > On 5/22/2012 8:45 AM, Michael Hennerich wrote: >> On 05/21/2012 06:37 PM, Jonathan Cameron wrote: >>> Michael cc'd for comments on core support of some stuff that is also >>> in frequency drivers down the end of the email. >>> >>> On 05/21/2012 10:50 AM, Johan Hovold wrote: >>>> On Sat, May 19, 2012 at 09:48:23AM +0100, Jonathan Cameron wrote: >>>>> On 05/18/2012 02:07 PM, Johan Hovold wrote: >>>>> So to summarise, we get the following new sysfs-entries for the ALS >>>>> (where the first set replace targetX_Y): >>>>> >>>>> out_currentX_currentY_raw r/w, (0..255), X in 0..2, Y in 0..4 >>>>> out_currentX_raw ro (0..255), X in 0..2 >>>>> >>>>> Is there any support in core for the first set or should I simply >>>>> rename my target attributes? >>> No support in the core yet for this sort of thing.. >>> Michael, any thoughts on this? In a sense it's very similar to >>> out_altvoltageX_frequencyY_raw etc... >>> >> Hi, >> >> Exactly it's similar to what we have on the DDS parts. >> The DDS parts would also benefit from a second index. >> >> Can someone think of an use case where we have 'differential' or 'modified' >> together with this pattern? >> >> If not we could use channel2 and introduce an new flag, but I fear >> that we end up using channel2 for too many things. >> So we should better introduce an new variable? >> > New variable. Tedious but channel2 is getting rather too overloaded. > > > Blah channel2 is not an option at all. We need to generate an index on the postfix. And we can't pass this information via info_mask. So ext_info could be your friend? -- Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif