* [PATCH 1/2] iio: hmc5843: Make it behave better as modules
@ 2012-05-28 15:12 Shubhrajyoti D
2012-05-28 15:12 ` [PATCH 2/2] iio: ak8975: " Shubhrajyoti D
2012-05-30 19:21 ` [PATCH 1/2] iio: hmc5843: " Jonathan Cameron
0 siblings, 2 replies; 5+ messages in thread
From: Shubhrajyoti D @ 2012-05-28 15:12 UTC (permalink / raw)
To: linux-iio; +Cc: Shubhrajyoti D
The memory regions of the probe and remove are move
to __devinit and __devexit respectively.
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
drivers/staging/iio/magnetometer/hmc5843.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c
index c1fa09f..6c3e50f 100644
--- a/drivers/staging/iio/magnetometer/hmc5843.c
+++ b/drivers/staging/iio/magnetometer/hmc5843.c
@@ -665,7 +665,7 @@ static const struct iio_info hmc5843_info = {
.driver_module = THIS_MODULE,
};
-static int hmc5843_probe(struct i2c_client *client,
+static int __devinit hmc5843_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
struct hmc5843_data *data;
@@ -704,7 +704,7 @@ exit:
return err;
}
-static int hmc5843_remove(struct i2c_client *client)
+static int __devexit hmc5843_remove(struct i2c_client *client)
{
struct iio_dev *indio_dev = i2c_get_clientdata(client);
@@ -755,7 +755,7 @@ static struct i2c_driver hmc5843_driver = {
},
.id_table = hmc5843_id,
.probe = hmc5843_probe,
- .remove = hmc5843_remove,
+ .remove = __devexit_p(hmc5843_remove),
.detect = hmc5843_detect,
.address_list = normal_i2c,
};
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] iio: ak8975: Make it behave better as modules
2012-05-28 15:12 [PATCH 1/2] iio: hmc5843: Make it behave better as modules Shubhrajyoti D
@ 2012-05-28 15:12 ` Shubhrajyoti D
2012-05-30 19:22 ` Jonathan Cameron
2012-05-30 19:21 ` [PATCH 1/2] iio: hmc5843: " Jonathan Cameron
1 sibling, 1 reply; 5+ messages in thread
From: Shubhrajyoti D @ 2012-05-28 15:12 UTC (permalink / raw)
To: linux-iio; +Cc: Shubhrajyoti D
The memory regions of the probe and remove are move
to __devinit and __devexit respectively.
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
dont have hardware. Untested.
drivers/staging/iio/magnetometer/ak8975.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/magnetometer/ak8975.c b/drivers/staging/iio/magnetometer/ak8975.c
index 5834e4a..7562caf 100644
--- a/drivers/staging/iio/magnetometer/ak8975.c
+++ b/drivers/staging/iio/magnetometer/ak8975.c
@@ -471,7 +471,7 @@ static const struct iio_info ak8975_info = {
.driver_module = THIS_MODULE,
};
-static int ak8975_probe(struct i2c_client *client,
+static int __devinit ak8975_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
struct ak8975_data *data;
@@ -545,7 +545,7 @@ exit:
return err;
}
-static int ak8975_remove(struct i2c_client *client)
+static int __devexit ak8975_remove(struct i2c_client *client)
{
struct iio_dev *indio_dev = i2c_get_clientdata(client);
struct ak8975_data *data = iio_priv(indio_dev);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] iio: hmc5843: Make it behave better as modules
2012-05-28 15:12 [PATCH 1/2] iio: hmc5843: Make it behave better as modules Shubhrajyoti D
2012-05-28 15:12 ` [PATCH 2/2] iio: ak8975: " Shubhrajyoti D
@ 2012-05-30 19:21 ` Jonathan Cameron
1 sibling, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2012-05-30 19:21 UTC (permalink / raw)
To: Shubhrajyoti D; +Cc: linux-iio
On 05/28/2012 04:12 PM, Shubhrajyoti D wrote:
> The memory regions of the probe and remove are move
> to __devinit and __devexit respectively.
>
Please send on to Greg KH.
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> drivers/staging/iio/magnetometer/hmc5843.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c
> index c1fa09f..6c3e50f 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843.c
> @@ -665,7 +665,7 @@ static const struct iio_info hmc5843_info = {
> .driver_module = THIS_MODULE,
> };
>
> -static int hmc5843_probe(struct i2c_client *client,
> +static int __devinit hmc5843_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> struct hmc5843_data *data;
> @@ -704,7 +704,7 @@ exit:
> return err;
> }
>
> -static int hmc5843_remove(struct i2c_client *client)
> +static int __devexit hmc5843_remove(struct i2c_client *client)
> {
> struct iio_dev *indio_dev = i2c_get_clientdata(client);
>
> @@ -755,7 +755,7 @@ static struct i2c_driver hmc5843_driver = {
> },
> .id_table = hmc5843_id,
> .probe = hmc5843_probe,
> - .remove = hmc5843_remove,
> + .remove = __devexit_p(hmc5843_remove),
> .detect = hmc5843_detect,
> .address_list = normal_i2c,
> };
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] iio: ak8975: Make it behave better as modules
2012-05-28 15:12 ` [PATCH 2/2] iio: ak8975: " Shubhrajyoti D
@ 2012-05-30 19:22 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2012-05-30 19:22 UTC (permalink / raw)
To: Shubhrajyoti D; +Cc: linux-iio
On 05/28/2012 04:12 PM, Shubhrajyoti D wrote:
> The memory regions of the probe and remove are move
> to __devinit and __devexit respectively.
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> dont have hardware. Untested.
Can't see any way this could cause trouble, so fine to merge
anyway...
>
> drivers/staging/iio/magnetometer/ak8975.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/magnetometer/ak8975.c b/drivers/staging/iio/magnetometer/ak8975.c
> index 5834e4a..7562caf 100644
> --- a/drivers/staging/iio/magnetometer/ak8975.c
> +++ b/drivers/staging/iio/magnetometer/ak8975.c
> @@ -471,7 +471,7 @@ static const struct iio_info ak8975_info = {
> .driver_module = THIS_MODULE,
> };
>
> -static int ak8975_probe(struct i2c_client *client,
> +static int __devinit ak8975_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> struct ak8975_data *data;
> @@ -545,7 +545,7 @@ exit:
> return err;
> }
>
> -static int ak8975_remove(struct i2c_client *client)
> +static int __devexit ak8975_remove(struct i2c_client *client)
> {
> struct iio_dev *indio_dev = i2c_get_clientdata(client);
> struct ak8975_data *data = iio_priv(indio_dev);
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] iio: hmc5843: Make it behave better as modules
@ 2012-06-04 9:41 Shubhrajyoti D
0 siblings, 0 replies; 5+ messages in thread
From: Shubhrajyoti D @ 2012-06-04 9:41 UTC (permalink / raw)
To: linux-iio; +Cc: gregkh, linux-kernel, Shubhrajyoti D
The memory regions of the probe and remove are move
to __devinit and __devexit respectively.
Acked-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
drivers/staging/iio/magnetometer/hmc5843.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c
index c1fa09f..6c3e50f 100644
--- a/drivers/staging/iio/magnetometer/hmc5843.c
+++ b/drivers/staging/iio/magnetometer/hmc5843.c
@@ -665,7 +665,7 @@ static const struct iio_info hmc5843_info = {
.driver_module = THIS_MODULE,
};
-static int hmc5843_probe(struct i2c_client *client,
+static int __devinit hmc5843_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
struct hmc5843_data *data;
@@ -704,7 +704,7 @@ exit:
return err;
}
-static int hmc5843_remove(struct i2c_client *client)
+static int __devexit hmc5843_remove(struct i2c_client *client)
{
struct iio_dev *indio_dev = i2c_get_clientdata(client);
@@ -755,7 +755,7 @@ static struct i2c_driver hmc5843_driver = {
},
.id_table = hmc5843_id,
.probe = hmc5843_probe,
- .remove = hmc5843_remove,
+ .remove = __devexit_p(hmc5843_remove),
.detect = hmc5843_detect,
.address_list = normal_i2c,
};
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-06-04 9:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-28 15:12 [PATCH 1/2] iio: hmc5843: Make it behave better as modules Shubhrajyoti D
2012-05-28 15:12 ` [PATCH 2/2] iio: ak8975: " Shubhrajyoti D
2012-05-30 19:22 ` Jonathan Cameron
2012-05-30 19:21 ` [PATCH 1/2] iio: hmc5843: " Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2012-06-04 9:41 Shubhrajyoti D
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).