From: Michael Hennerich <michael.hennerich@analog.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch 2/2 -next] iio: frequency: adf4350: fix an initialization
Date: Fri, 8 Jun 2012 09:24:12 +0200 [thread overview]
Message-ID: <4FD1A89C.3050607@analog.com> (raw)
In-Reply-To: <20120608065537.GD26673@elgon.mountain>
On 06/08/2012 08:55 AM, Dan Carpenter wrote:
> Sparse complains about this:
> drivers/iio/frequency/adf4350.c:58:29: warning: Initializer entry defined twice
> drivers/iio/frequency/adf4350.c:59:10: also defined here
>
> It looks like '|' was intended here instead of ','.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> Guess work on my part.
>
> diff --git a/drivers/iio/frequency/adf4350.c b/drivers/iio/frequency/adf4350.c
> index 4729bba..59fbb3ae 100644
> --- a/drivers/iio/frequency/adf4350.c
> +++ b/drivers/iio/frequency/adf4350.c
> @@ -54,7 +54,7 @@ struct adf4350_state {
> static struct adf4350_platform_data default_pdata = {
> .clkin = 122880000,
> .channel_spacing = 10000,
> - .r2_user_settings = ADF4350_REG2_PD_POLARITY_POS,
> + .r2_user_settings = ADF4350_REG2_PD_POLARITY_POS |
> ADF4350_REG2_CHARGE_PUMP_CURR_uA(2500),
> .r3_user_settings = ADF4350_REG3_12BIT_CLKDIV_MODE(0),
> .r4_user_settings = ADF4350_REG4_OUTPUT_PWR(3) |
>
--
Greetings,
Michael
--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif
prev parent reply other threads:[~2012-06-08 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 6:55 [patch 2/2 -next] iio: frequency: adf4350: fix an initialization Dan Carpenter
2012-06-08 7:24 ` Michael Hennerich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD1A89C.3050607@analog.com \
--to=michael.hennerich@analog.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@cam.ac.uk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).