* [patch 2/2 -next] iio: frequency: adf4350: fix an initialization
@ 2012-06-08 6:55 Dan Carpenter
2012-06-08 7:24 ` Michael Hennerich
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-06-08 6:55 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Greg Kroah-Hartman, Michael Hennerich, linux-iio, kernel-janitors
Sparse complains about this:
drivers/iio/frequency/adf4350.c:58:29: warning: Initializer entry defined twice
drivers/iio/frequency/adf4350.c:59:10: also defined here
It looks like '|' was intended here instead of ','.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Guess work on my part.
diff --git a/drivers/iio/frequency/adf4350.c b/drivers/iio/frequency/adf4350.c
index 4729bba..59fbb3ae 100644
--- a/drivers/iio/frequency/adf4350.c
+++ b/drivers/iio/frequency/adf4350.c
@@ -54,7 +54,7 @@ struct adf4350_state {
static struct adf4350_platform_data default_pdata = {
.clkin = 122880000,
.channel_spacing = 10000,
- .r2_user_settings = ADF4350_REG2_PD_POLARITY_POS,
+ .r2_user_settings = ADF4350_REG2_PD_POLARITY_POS |
ADF4350_REG2_CHARGE_PUMP_CURR_uA(2500),
.r3_user_settings = ADF4350_REG3_12BIT_CLKDIV_MODE(0),
.r4_user_settings = ADF4350_REG4_OUTPUT_PWR(3) |
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 2/2 -next] iio: frequency: adf4350: fix an initialization
2012-06-08 6:55 [patch 2/2 -next] iio: frequency: adf4350: fix an initialization Dan Carpenter
@ 2012-06-08 7:24 ` Michael Hennerich
0 siblings, 0 replies; 2+ messages in thread
From: Michael Hennerich @ 2012-06-08 7:24 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jonathan Cameron, Greg Kroah-Hartman, linux-iio@vger.kernel.org,
kernel-janitors@vger.kernel.org
On 06/08/2012 08:55 AM, Dan Carpenter wrote:
> Sparse complains about this:
> drivers/iio/frequency/adf4350.c:58:29: warning: Initializer entry defined twice
> drivers/iio/frequency/adf4350.c:59:10: also defined here
>
> It looks like '|' was intended here instead of ','.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> Guess work on my part.
>
> diff --git a/drivers/iio/frequency/adf4350.c b/drivers/iio/frequency/adf4350.c
> index 4729bba..59fbb3ae 100644
> --- a/drivers/iio/frequency/adf4350.c
> +++ b/drivers/iio/frequency/adf4350.c
> @@ -54,7 +54,7 @@ struct adf4350_state {
> static struct adf4350_platform_data default_pdata = {
> .clkin = 122880000,
> .channel_spacing = 10000,
> - .r2_user_settings = ADF4350_REG2_PD_POLARITY_POS,
> + .r2_user_settings = ADF4350_REG2_PD_POLARITY_POS |
> ADF4350_REG2_CHARGE_PUMP_CURR_uA(2500),
> .r3_user_settings = ADF4350_REG3_12BIT_CLKDIV_MODE(0),
> .r4_user_settings = ADF4350_REG4_OUTPUT_PWR(3) |
>
--
Greetings,
Michael
--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-08 7:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-08 6:55 [patch 2/2 -next] iio: frequency: adf4350: fix an initialization Dan Carpenter
2012-06-08 7:24 ` Michael Hennerich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).