From: Jonathan Cameron <jic23@cam.ac.uk>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio staging: fix typos in simple dummy driver
Date: Fri, 15 Jun 2012 13:42:41 +0100 [thread overview]
Message-ID: <4FDB2DC1.3080703@cam.ac.uk> (raw)
In-Reply-To: <1339718059-9101-1-git-send-email-pmeerw@pmeerw.net>
On 6/15/2012 12:54 AM, Peter Meerwald wrote:
I never could spell... Thanks for this Peter!
> Signed-off-by: Peter Meerwald<pmeerw@pmeerw.net>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> drivers/staging/iio/iio_simple_dummy.c | 10 +++++-----
> drivers/staging/iio/iio_simple_dummy_buffer.c | 4 ++--
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/iio/iio_simple_dummy.c b/drivers/staging/iio/iio_simple_dummy.c
> index 3104119..155a49a 100644
> --- a/drivers/staging/iio/iio_simple_dummy.c
> +++ b/drivers/staging/iio/iio_simple_dummy.c
> @@ -27,7 +27,7 @@
>
> /*
> * A few elements needed to fake a bus for this driver
> - * Note instances parmeter controls how many of these
> + * Note instances parameter controls how many of these
> * dummy devices are registered.
> */
> static unsigned instances = 1;
> @@ -178,7 +178,7 @@ static struct iio_chan_spec iio_dummy_channels[] = {
> .scan_index = accelx,
> .scan_type = { /* Description of storage in buffer */
> .sign = 's', /* signed */
> - .realbits = 16, /* 12 bits */
> + .realbits = 16, /* 16 bits */
doh! That's bad ;)
> .storagebits = 16, /* 16 bits used for storage */
> .shift = 0, /* zero shift */
> },
> @@ -285,9 +285,9 @@ static int iio_dummy_read_raw(struct iio_dev *indio_dev,
> * iio_dummy_write_raw() - data write function.
> * @indio_dev: the struct iio_dev associated with this device instance
> * @chan: the channel whose data is to be read
> - * @val: first element of returned value (typically INT)
> - * @val2: second element of returned value (typically MICRO)
> - * @mask: what we actually want to read. 0 is the channel, everything else
> + * @val: first element of value to set (typically INT)
> + * @val2: second element of value to set (typically MICRO)
> + * @mask: what we actually want to write. 0 is the channel, everything else
> * is as per the info_mask in iio_chan_spec.
> *
> * Note that all raw writes are assumed IIO_VAL_INT and info mask elements
> diff --git a/drivers/staging/iio/iio_simple_dummy_buffer.c b/drivers/staging/iio/iio_simple_dummy_buffer.c
> index fdfc873..3e43025 100644
> --- a/drivers/staging/iio/iio_simple_dummy_buffer.c
> +++ b/drivers/staging/iio/iio_simple_dummy_buffer.c
> @@ -67,8 +67,8 @@ static irqreturn_t iio_simple_dummy_trigger_h(int irq, void *p)
> * software culled hardware scans:
> * occasionally a driver may process the nearest hardware
> * scan to avoid storing elements that are not desired. This
> - * is the fidliest option by far.
> - * Here lets pretend we have random access. And the values are
> + * is the fiddliest option by far.
> + * Here let's pretend we have random access. And the values are
> * in the constant table fakedata.
> */
> int i, j;
next prev parent reply other threads:[~2012-06-15 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 23:54 [PATCH] iio staging: fix typos in simple dummy driver Peter Meerwald
2012-06-15 12:42 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-15 17:27 Peter Meerwald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDB2DC1.3080703@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).