From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4FEEF379.2040700@kernel.org> Date: Sat, 30 Jun 2012 13:39:21 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Lars-Peter Clausen CC: Jonathan Cameron , linux-iio@vger.kernel.org Subject: Re: [PATCH] staging:iio:ad7793: Fix scan index for the "shorted" channel References: <1340787507-9372-1-git-send-email-lars@metafoo.de> In-Reply-To: <1340787507-9372-1-git-send-email-lars@metafoo.de> Content-Type: text/plain; charset=ISO-8859-1 List-ID: On 06/27/2012 09:58 AM, Lars-Peter Clausen wrote: > The code expects the scan index to match the offset of the channel into the > channel array. For the "shorted" the offset is 3, but the scan index is set to > 2. Also the scan index 2 is already taken by the previous channel. As a result > the "shorted" channel will appear to be selected if the previous channel is > selected and vice versa and it is not possible to sample the "shorted" channel > in buffered mode. > merged. Thanks > Signed-off-by: Lars-Peter Clausen > --- > drivers/staging/iio/adc/ad7793.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7793.c b/drivers/staging/iio/adc/ad7793.c > index 89873f4..76fdd71 100644 > --- a/drivers/staging/iio/adc/ad7793.c > +++ b/drivers/staging/iio/adc/ad7793.c > @@ -758,7 +758,7 @@ static const struct ad7793_chip_info ad7793_chip_info_tbl[] = { > .address = AD7793_CH_AIN1M_AIN1M, > .info_mask = IIO_CHAN_INFO_RAW_SEPARATE_BIT | > IIO_CHAN_INFO_SCALE_SHARED_BIT, > - .scan_index = 2, > + .scan_index = 3, > .scan_type = IIO_ST('s', 24, 32, 0) > }, > .channel[4] = { > @@ -831,7 +831,7 @@ static const struct ad7793_chip_info ad7793_chip_info_tbl[] = { > .address = AD7793_CH_AIN1M_AIN1M, > .info_mask = IIO_CHAN_INFO_RAW_SEPARATE_BIT | > IIO_CHAN_INFO_SCALE_SHARED_BIT, > - .scan_index = 2, > + .scan_index = 3, > .scan_type = IIO_ST('s', 16, 32, 0) > }, > .channel[4] = { >