* [PATCH 1/3] iio staging: missing newline in printf
@ 2012-06-30 22:47 Peter Meerwald
2012-06-30 22:47 ` [PATCH 2/3] iio: another typo in comment Peter Meerwald
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Peter Meerwald @ 2012-06-30 22:47 UTC (permalink / raw)
To: linux-iio; +Cc: Peter Meerwald
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
drivers/staging/iio/Documentation/iio_utils.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/Documentation/iio_utils.h b/drivers/staging/iio/Documentation/iio_utils.h
index 5244fa0..cf32ae0 100644
--- a/drivers/staging/iio/Documentation/iio_utils.h
+++ b/drivers/staging/iio/Documentation/iio_utils.h
@@ -453,7 +453,7 @@ inline int find_type_by_name(const char *name, const char *type)
dp = opendir(iio_dir);
if (dp == NULL) {
- printf("No industrialio devices available");
+ printf("No industrialio devices available\n");
return -ENODEV;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] iio: another typo in comment
2012-06-30 22:47 [PATCH 1/3] iio staging: missing newline in printf Peter Meerwald
@ 2012-06-30 22:47 ` Peter Meerwald
2012-07-03 17:27 ` Jonathan Cameron
2012-06-30 22:47 ` [PATCH 3/3] iio: cleanup buffer.h comments Peter Meerwald
2012-07-03 17:30 ` [PATCH 1/3] iio staging: missing newline in printf Jonathan Cameron
2 siblings, 1 reply; 6+ messages in thread
From: Peter Meerwald @ 2012-06-30 22:47 UTC (permalink / raw)
To: linux-iio; +Cc: Peter Meerwald
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
include/linux/iio/iio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index 2afbb6f..72f8851 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -220,7 +220,7 @@ ssize_t iio_enum_write(struct iio_dev *indio_dev,
* unlike modifiers.
* @datasheet_name: A name used in in-kernel mapping of channels. It should
* correspond to the first name that the channel is referred
- * to by in the datasheet (e.g. IND), or the nearest
+ * to in the datasheet (e.g. IND), or the nearest
* possible compound name (e.g. IND-INC).
* @modified: Does a modifier apply to this channel. What these are
* depends on the channel type. Modifier is set in
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] iio: cleanup buffer.h comments
2012-06-30 22:47 [PATCH 1/3] iio staging: missing newline in printf Peter Meerwald
2012-06-30 22:47 ` [PATCH 2/3] iio: another typo in comment Peter Meerwald
@ 2012-06-30 22:47 ` Peter Meerwald
2012-07-03 17:30 ` Jonathan Cameron
2012-07-03 17:30 ` [PATCH 1/3] iio staging: missing newline in printf Jonathan Cameron
2 siblings, 1 reply; 6+ messages in thread
From: Peter Meerwald @ 2012-06-30 22:47 UTC (permalink / raw)
To: linux-iio; +Cc: Peter Meerwald
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
include/linux/iio/buffer.h | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/include/linux/iio/buffer.h b/include/linux/iio/buffer.h
index ad4fb1a..2a2b6b4 100644
--- a/include/linux/iio/buffer.h
+++ b/include/linux/iio/buffer.h
@@ -85,7 +85,7 @@ struct iio_buffer {
/**
* iio_buffer_init() - Initialize the buffer structure
- * @buffer: buffer to be initialized
+ * @buffer: buffer to be initialized
**/
void iio_buffer_init(struct iio_buffer *buffer);
@@ -107,8 +107,9 @@ int iio_scan_mask_query(struct iio_dev *indio_dev,
/**
* iio_scan_mask_set() - set particular bit in the scan mask
- * @buffer: the buffer whose scan mask we are interested in
- * @bit: the bit to be set.
+ * @indio_dev IIO device structure
+ * @buffer: the buffer whose scan mask we are interested in
+ * @bit: the bit to be set.
**/
int iio_scan_mask_set(struct iio_dev *indio_dev,
struct iio_buffer *buffer, int bit);
@@ -116,8 +117,8 @@ int iio_scan_mask_set(struct iio_dev *indio_dev,
/**
* iio_push_to_buffer() - push to a registered buffer.
* @buffer: IIO buffer structure for device
- * @scan: Full scan.
- * @timestamp:
+ * @data: the data to push to the buffer
+ * @timestamp: timestamp to associate with the data
*/
int iio_push_to_buffer(struct iio_buffer *buffer, unsigned char *data,
s64 timestamp);
@@ -126,7 +127,9 @@ int iio_update_demux(struct iio_dev *indio_dev);
/**
* iio_buffer_register() - register the buffer with IIO core
- * @indio_dev: device with the buffer to be registered
+ * @indio_dev: device with the buffer to be registered
+ * @channels: the channel descriptions used to construct buffer
+ * @num_channels: the number of channels
**/
int iio_buffer_register(struct iio_dev *indio_dev,
const struct iio_chan_spec *channels,
@@ -134,7 +137,7 @@ int iio_buffer_register(struct iio_dev *indio_dev,
/**
* iio_buffer_unregister() - unregister the buffer from IIO core
- * @indio_dev: the device with the buffer to be unregistered
+ * @indio_dev: the device with the buffer to be unregistered
**/
void iio_buffer_unregister(struct iio_dev *indio_dev);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] iio: another typo in comment
2012-06-30 22:47 ` [PATCH 2/3] iio: another typo in comment Peter Meerwald
@ 2012-07-03 17:27 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2012-07-03 17:27 UTC (permalink / raw)
To: Peter Meerwald; +Cc: linux-iio
On 06/30/2012 11:47 PM, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> ---
> include/linux/iio/iio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index 2afbb6f..72f8851 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -220,7 +220,7 @@ ssize_t iio_enum_write(struct iio_dev *indio_dev,
> * unlike modifiers.
> * @datasheet_name: A name used in in-kernel mapping of channels. It should
> * correspond to the first name that the channel is referred
> - * to by in the datasheet (e.g. IND), or the nearest
> + * to in the datasheet (e.g. IND), or the nearest
Nope. The original is correct English. Referred to implies some sort of
transference, referred to by implies that this name is used.
There might be a better way of putting it, but it's not that uncommon a
usage.
> * possible compound name (e.g. IND-INC).
> * @modified: Does a modifier apply to this channel. What these are
> * depends on the channel type. Modifier is set in
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] iio: cleanup buffer.h comments
2012-06-30 22:47 ` [PATCH 3/3] iio: cleanup buffer.h comments Peter Meerwald
@ 2012-07-03 17:30 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2012-07-03 17:30 UTC (permalink / raw)
To: Peter Meerwald; +Cc: linux-iio
On 06/30/2012 11:47 PM, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
merged thanks.
> ---
> include/linux/iio/buffer.h | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/include/linux/iio/buffer.h b/include/linux/iio/buffer.h
> index ad4fb1a..2a2b6b4 100644
> --- a/include/linux/iio/buffer.h
> +++ b/include/linux/iio/buffer.h
> @@ -85,7 +85,7 @@ struct iio_buffer {
>
> /**
> * iio_buffer_init() - Initialize the buffer structure
> - * @buffer: buffer to be initialized
> + * @buffer: buffer to be initialized
> **/
> void iio_buffer_init(struct iio_buffer *buffer);
>
> @@ -107,8 +107,9 @@ int iio_scan_mask_query(struct iio_dev *indio_dev,
>
> /**
> * iio_scan_mask_set() - set particular bit in the scan mask
> - * @buffer: the buffer whose scan mask we are interested in
> - * @bit: the bit to be set.
> + * @indio_dev IIO device structure
> + * @buffer: the buffer whose scan mask we are interested in
> + * @bit: the bit to be set.
> **/
> int iio_scan_mask_set(struct iio_dev *indio_dev,
> struct iio_buffer *buffer, int bit);
> @@ -116,8 +117,8 @@ int iio_scan_mask_set(struct iio_dev *indio_dev,
> /**
> * iio_push_to_buffer() - push to a registered buffer.
> * @buffer: IIO buffer structure for device
> - * @scan: Full scan.
> - * @timestamp:
> + * @data: the data to push to the buffer
> + * @timestamp: timestamp to associate with the data
> */
> int iio_push_to_buffer(struct iio_buffer *buffer, unsigned char *data,
> s64 timestamp);
> @@ -126,7 +127,9 @@ int iio_update_demux(struct iio_dev *indio_dev);
>
> /**
> * iio_buffer_register() - register the buffer with IIO core
> - * @indio_dev: device with the buffer to be registered
> + * @indio_dev: device with the buffer to be registered
> + * @channels: the channel descriptions used to construct buffer
> + * @num_channels: the number of channels
> **/
> int iio_buffer_register(struct iio_dev *indio_dev,
> const struct iio_chan_spec *channels,
> @@ -134,7 +137,7 @@ int iio_buffer_register(struct iio_dev *indio_dev,
>
> /**
> * iio_buffer_unregister() - unregister the buffer from IIO core
> - * @indio_dev: the device with the buffer to be unregistered
> + * @indio_dev: the device with the buffer to be unregistered
> **/
> void iio_buffer_unregister(struct iio_dev *indio_dev);
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] iio staging: missing newline in printf
2012-06-30 22:47 [PATCH 1/3] iio staging: missing newline in printf Peter Meerwald
2012-06-30 22:47 ` [PATCH 2/3] iio: another typo in comment Peter Meerwald
2012-06-30 22:47 ` [PATCH 3/3] iio: cleanup buffer.h comments Peter Meerwald
@ 2012-07-03 17:30 ` Jonathan Cameron
2 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2012-07-03 17:30 UTC (permalink / raw)
To: Peter Meerwald; +Cc: linux-iio
On 06/30/2012 11:47 PM, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Merged thanks.
> ---
> drivers/staging/iio/Documentation/iio_utils.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/Documentation/iio_utils.h b/drivers/staging/iio/Documentation/iio_utils.h
> index 5244fa0..cf32ae0 100644
> --- a/drivers/staging/iio/Documentation/iio_utils.h
> +++ b/drivers/staging/iio/Documentation/iio_utils.h
> @@ -453,7 +453,7 @@ inline int find_type_by_name(const char *name, const char *type)
>
> dp = opendir(iio_dir);
> if (dp == NULL) {
> - printf("No industrialio devices available");
> + printf("No industrialio devices available\n");
> return -ENODEV;
> }
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-03 17:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-30 22:47 [PATCH 1/3] iio staging: missing newline in printf Peter Meerwald
2012-06-30 22:47 ` [PATCH 2/3] iio: another typo in comment Peter Meerwald
2012-07-03 17:27 ` Jonathan Cameron
2012-06-30 22:47 ` [PATCH 3/3] iio: cleanup buffer.h comments Peter Meerwald
2012-07-03 17:30 ` Jonathan Cameron
2012-07-03 17:30 ` [PATCH 1/3] iio staging: missing newline in printf Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).