From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: iio_buffer_register: Use correct channel when calculating masklength
Date: Tue, 03 Jul 2012 18:36:05 +0100 [thread overview]
Message-ID: <4FF32D85.1040503@kernel.org> (raw)
In-Reply-To: <1341233576-9082-1-git-send-email-lars@metafoo.de>
On 07/02/2012 01:52 PM, Lars-Peter Clausen wrote:
> The channel set assigned to the iio device is not necessarily the same has the
> channel set passed to iio_buffer_register. So to avoid possible complications
> always work with the channel set pass to iio_buffer_register and ignore the
> channel set assigned to the iio device.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
merged to fixes. Thanks
> ---
> drivers/iio/industrialio-buffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index bb88377..d074051 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -292,7 +292,7 @@ int iio_buffer_register(struct iio_dev *indio_dev,
> if (channels[i].scan_index >
> (int)indio_dev->masklength - 1)
> indio_dev->masklength
> - = indio_dev->channels[i].scan_index + 1;
> + = channels[i].scan_index + 1;
>
> ret = iio_buffer_add_channel_sysfs(indio_dev,
> &channels[i]);
>
prev parent reply other threads:[~2012-07-03 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 12:52 [PATCH] iio: iio_buffer_register: Use correct channel when calculating masklength Lars-Peter Clausen
2012-07-03 17:36 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF32D85.1040503@kernel.org \
--to=jic23@kernel.org \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).