From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, lars@metafoo.de
Subject: Re: [PATCH v5] iio: add adjd_s311 I2C digital color sensor driver
Date: Thu, 12 Jul 2012 20:24:41 +0100 [thread overview]
Message-ID: <4FFF2479.6000801@kernel.org> (raw)
In-Reply-To: <1341955964-17975-1-git-send-email-pmeerw@pmeerw.net>
On 07/10/2012 10:32 PM, Peter Meerwald wrote:
> sensor has 4 channels (10-bit each, R/G/B and clear), sensitivity
> and gain is controlled in the driver by ext_info integration_time
> and CHAN_INFO_HARDWAREGAIN
>
> driver supports triggered buffer and IIO_CHAN_INFO_RAW to get the
> sensor data
>
> v5: address comments by Jonathan Cameron
> * use macro for channel declaration
> * get timestamp right before measurement
> * cleanups
>
> v4: address comments by Lars-Peter Clausen
> * make sure trigger handler is exited with iio_trigger_notify_done()
> and IRQ_HANDLED
> * kfree()/kalloc() -> krealloc()
>
> v3:
> * fix warnings
>
> v2: address comments by Lars-Peter Clausen
> * buffer allocation now in update_scan_mode instead of in trigger
> handler
> * simplify trigger code (assume active_scan_mask is not empty, use
> for_each_set_bit, use iio_push_to_buffer)
> * reorder entry in Makefile and Kconfig
> * fix remove
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
merged to togreg branch and pull request sent.
prev parent reply other threads:[~2012-07-12 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 21:32 [PATCH v5] iio: add adjd_s311 I2C digital color sensor driver Peter Meerwald
2012-07-12 19:24 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFF2479.6000801@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).