From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931C91547E2 for ; Mon, 9 Dec 2024 17:44:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733766261; cv=none; b=WB0XAm8s8fvf6hT1PVYySXVB78+dTym3bDDMfQeTd2fvbcjCeLihMpydY5B7IKBxwFsZ1PzZhj0MDlEtLjLmAhyNjDIs3rVfudBZpPk4m1vfpkw1CrhZ7qFPwJY/hKLKxvAGgo61VhGWGohna6XNoXXrmV5L2HVSaD2yo5Ar5co= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733766261; c=relaxed/simple; bh=T8VsNOEm3fdtOz4g+8Npq3QFd9DXTd9hJ4Mx+0kU1Dg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oxu73aU5DA0FLSNAy/w7rWBKnun63sKwB5Z9Mz0LszA+ycEcU15ZhiobPE3ZKR8azPDYJwPTVqMKg+Xp2lH1OAd3DX+3SKwxRrzJlU7cXSfp8ClZoltkx+ZGPAj0Ev8uBRlIagpX4e7YRnuOOyBegpYanjUM7vIR09XXp1YpCHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=0eMW83n5; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="0eMW83n5" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-71deb3745easo296765a34.3 for ; Mon, 09 Dec 2024 09:44:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1733766256; x=1734371056; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NQaHY150Yps34xQsPyk4V8n2PV48YCsChjwMePfbEZc=; b=0eMW83n5rJvm3Z1VPKBQr0LAAEimjThUcIhFCLXzYmgRdNvLfmjCrkiD/xkEybgWLZ EBI1dbbFooV6lFkfmj+F/exE60/f2wwlfSf1aiJY2DGHnZ0kNIhIvmHe9XZs66DASfYF 67twLwgEE2pf1i9ULMP/IaQYLIrwOOfuI0/w8WoBE7cBuFwUDTlM0DF8tc4TeD2pfaZx Jlm3ymiPR6CtNqIa5yGHXJI6t8EefPNZsAQ5gg51kmsHcCYJmrt8V0y9NEFRQL9J39Mm a/k87wdGm/9Pib0+1l29XsxUwD4KybFXgVpwKDrEGdgZytWnNMNKfc2DH95hBmXP0U8D 0AUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733766256; x=1734371056; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NQaHY150Yps34xQsPyk4V8n2PV48YCsChjwMePfbEZc=; b=X94uZ3jtHubPh+tqb4LOszxAGsTfE+39os4xVCD7FZV3BeidAeaS3CI7j3pTohyviW 6VP3bjmzs1oMlFHOgbut3rdkoqJz3/GBKvLriJ2R2IQGkWctdvWZdpIt4jTMqAplKbIT BWlPE3O6SBWo2I32bKZL5lP04R1NtYSoWFqHOWeRg0xOa3rKiT778LyeKlwmG1wt3q0H PSPhw/WSQFwlo7cVnSM6enXL9FClvcNSA81GkEz3Cqu7FQAL20dJ4lTrgmLbaJwUsbF4 qnTv+n5KnKGRgSPovWGTgWgSrrnEenO4lCxFEgoTOuMXnX9JTnZ9aKsSdFPlCeS6ZaLg XVzQ== X-Forwarded-Encrypted: i=1; AJvYcCXQW8/9l6bmApRk+9uAd/kiwebH88VVkn8Nsk95TWfOvydK1qSzyuUGGAibXM139m2Pv4aexYF/bQs=@vger.kernel.org X-Gm-Message-State: AOJu0YywTtReLKhC5X3d6uaxb/AfRneZZLaRX/zAq+wu4uoXOvETGIKz BjzTlTjbfThG8uHaLdNTonhd53P4u3KcwzfmwcOIc57E5BQdqQELTdl97wt99Gw= X-Gm-Gg: ASbGncs7ZHd8zOlkl3Ap3Tp2O6+wylczFsGtMd4J7RrUf+n5ajVNn57aeqZucqmtFwN LL+5eGYUGxOOXMhFCIWwPWnCgRnAd7F8RW7X3fq8CAoKbsLWFrPjxJCEnn3HkOgO0yrAeqVt4Lm Z2PGH95Rm1OQ4ZB2G4MGcysGD9Gr6ywndMlMpOVOxldOYYSq+a1DniQyfh6eus4MgkWlgnoZM7I Bhr9LeGjlI1P9DZhUVVK1Z4uSMcBqQrAAr3s7XnQoALvuQbyiIR0zsFF3hPd52cu4XmvzjIrP2O vCRFztfK2p8= X-Google-Smtp-Source: AGHT+IFb81lytRSGzGy7brox5UjxhmObKKJPioRXNthRoTofZyWXpYB3n+qfmyKwwp6491Ja7RrpNg== X-Received: by 2002:a05:6808:1883:b0:3ea:57cf:7c26 with SMTP id 5614622812f47-3eb66e12187mr1006950b6e.19.1733766256635; Mon, 09 Dec 2024 09:44:16 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3eb57b69471sm551260b6e.45.2024.12.09.09.44.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Dec 2024 09:44:16 -0800 (PST) Message-ID: <4be8bebb-7db3-43e5-b00e-95ebf7114d80@baylibre.com> Date: Mon, 9 Dec 2024 11:44:14 -0600 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 7/8] dt-bindings: iio: adc: add ad4851 To: "Miclaus, Antoniu" , "jic23@kernel.org" , "robh@kernel.org" , "conor+dt@kernel.org" , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" Cc: Conor Dooley References: <20241129153546.63584-1-antoniu.miclaus@analog.com> <20241129153546.63584-8-antoniu.miclaus@analog.com> <2d760894-bda5-4000-9598-914b830333a7@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/9/24 8:02 AM, Miclaus, Antoniu wrote: > > > -- > Antoniu Miclăuş > >> -----Original Message----- >> From: David Lechner >> Sent: Thursday, December 5, 2024 2:46 AM >> To: Miclaus, Antoniu ; jic23@kernel.org; >> robh@kernel.org; conor+dt@kernel.org; linux-iio@vger.kernel.org; >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >> pwm@vger.kernel.org >> Cc: Conor Dooley >> Subject: Re: [PATCH v7 7/8] dt-bindings: iio: adc: add ad4851 >> >> [External] >> >> On 11/29/24 9:35 AM, Antoniu Miclaus wrote: >>> Add devicetree bindings for ad485x family. >>> >>> Reviewed-by: Conor Dooley >>> Signed-off-by: Antoniu Miclaus >>> --- >>> changes in v7: >>> - add adc channels support >> >> What is the reason for this change? In a previous version of this series, >> you explained that we didn't want to specify diff-channels in the DT >> because there was a use case to use channels as both single-ended and >> differential at runtime. So I am surprised to see this being added now. >> > We had a discussion and we decided to go for the dt approach for specifying > the channels configuration, even though in the first place we wanted to avoid this. > Overall it makes more sense. OK, in that case we will also want to make use of the standard "bipolar" property from adc.yaml as well since the chip differentiates between unipolar and bipolar inputs. Also, might want to drop Conor's review tag and give an explanation in the next revision since adding these channel properties is a bit of a big change compared to the version he reviewed. > >>> +patternProperties: >>> + "^channel(@[0-7])?$": >>> + $ref: adc.yaml >>> + type: object >>> + description: Represents the channels which are connected to the ADC. >>> + >>> + properties: >>> + reg: >>> + description: The channel number in single-ended mode. >>> + minimum: 0 >>> + maximum: 7 >>> + >>> + diff-channels: true >>> + >>> + required: >>> + - reg >>> + >>> + additionalProperties: false >>> +