From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Peter Meerwald <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: add driver for si114x ambient light / proximity sensors
Date: Sun, 09 Sep 2012 12:47:09 +0200 [thread overview]
Message-ID: <504C73AD.807@metafoo.de> (raw)
In-Reply-To: <504B780F.8090305@kernel.org>
On 09/08/2012 06:53 PM, Jonathan Cameron wrote:
> On 09/07/2012 12:36 AM, Peter Meerwald wrote:
[...]
>> +
>> +struct si114x_platform_data {
>> + bool use_irq;
> It's a bit nasty, but you could drop this and rely on client->irq = NO_IRQ
> in the platform data. If only the no irq = 0 had always been enforced...
NO_IRQ constant is deprecated anyway, and 0 is the new "no irq". So just
checking if client->irq is 0 should be fine to find out whether to use IRQs or not.
>> + int irq_flags;
> Which flags actually make sense here? Just curious really.
>> +};
>> +
>> +#endif /* SI114X_H */
>> +
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-09 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 23:36 [PATCH] iio: add driver for si114x ambient light / proximity sensors Peter Meerwald
2012-09-08 16:53 ` Jonathan Cameron
2012-09-09 10:47 ` Lars-Peter Clausen [this message]
2012-09-10 6:54 ` Peter Meerwald
2012-09-29 13:45 ` Peter Meerwald
2012-10-13 20:25 ` Jonathan Cameron
2012-10-17 15:44 ` Peter Meerwald
2012-10-18 8:54 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504C73AD.807@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).