From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ppsw-50.csi.cam.ac.uk ([131.111.8.150]:37264 "EHLO ppsw-50.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755004Ab2IMM0G (ORCPT ); Thu, 13 Sep 2012 08:26:06 -0400 Message-ID: <5051D0E0.1020505@kernel.org> Date: Thu, 13 Sep 2012 13:26:08 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: anish singh CC: Lars-Peter Clausen , cbou@mail.ru, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH] [RFC]power: battery: Generic battery driver using IIO References: <1347291621-8530-1-git-send-email-anish198519851985@gmail.com> <504F0B9B.2050504@metafoo.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org >> > Thanks Lars, all of your comments are valid and I will accordingly update. > I am waiting for some more review comments if there is any and will send > the updated code. Beware of that strategy as I for one am guilty of the old approach of 'oh look someone else has commented, I'll wait for the next version before taking a look' - particularly when it's a good reviewer like Lars