From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: remove useless irq_enabled variable in at91
Date: Sat, 13 Oct 2012 10:37:55 +0100 [thread overview]
Message-ID: <50793673.3020104@kernel.org> (raw)
In-Reply-To: <1350115595-7107-1-git-send-email-pmeerw@pmeerw.net>
On 10/13/2012 09:06 AM, Peter Meerwald wrote:
> irq_enabled is only set, but never read
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Added to togreg branch of iio.git thanks.
> ---
> drivers/iio/adc/at91_adc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index 3ed94bf..b3ba8af 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -46,7 +46,6 @@ struct at91_adc_state {
> struct clk *clk;
> bool done;
> int irq;
> - bool irq_enabled;
> u16 last_value;
> struct mutex lock;
> u8 num_channels;
> @@ -85,7 +84,6 @@ static irqreturn_t at91_adc_trigger_handler(int irq, void *p)
> buffer->access->store_to(buffer, (u8 *)st->buffer);
>
> iio_trigger_notify_done(idev->trig);
> - st->irq_enabled = true;
>
> /* Needed to ACK the DRDY interruption */
> at91_adc_readl(st, AT91_ADC_LCDR);
> @@ -106,7 +104,6 @@ static irqreturn_t at91_adc_eoc_trigger(int irq, void *private)
>
> if (iio_buffer_enabled(idev)) {
> disable_irq_nosync(irq);
> - st->irq_enabled = false;
> iio_trigger_poll(idev->trig, iio_get_time_ns());
> } else {
> st->last_value = at91_adc_readl(st, AT91_ADC_LCDR);
>
prev parent reply other threads:[~2012-10-13 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 8:06 [PATCH] iio: remove useless irq_enabled variable in at91 Peter Meerwald
2012-10-13 8:06 ` [PATCH] iio: use iio_push_to_buffer() in at91 driver Peter Meerwald
2012-10-13 9:40 ` Jonathan Cameron
2012-10-13 8:06 ` [PATCH] staging iio: use iio_trigger_generic_data_rdy_poll() in accel/adis16209,adis16240 driver Peter Meerwald
2012-10-13 9:42 ` Jonathan Cameron
2012-10-13 8:06 ` [PATCH] iio: fix spelling of Accelerometer in Kconfig Peter Meerwald
2012-10-13 9:43 ` Jonathan Cameron
2012-10-13 9:37 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50793673.3020104@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).