From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:45636 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752960Ab2JMJh5 (ORCPT ); Sat, 13 Oct 2012 05:37:57 -0400 Message-ID: <50793673.3020104@kernel.org> Date: Sat, 13 Oct 2012 10:37:55 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Peter Meerwald CC: linux-iio@vger.kernel.org Subject: Re: [PATCH] iio: remove useless irq_enabled variable in at91 References: <1350115595-7107-1-git-send-email-pmeerw@pmeerw.net> In-Reply-To: <1350115595-7107-1-git-send-email-pmeerw@pmeerw.net> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 10/13/2012 09:06 AM, Peter Meerwald wrote: > irq_enabled is only set, but never read > > Signed-off-by: Peter Meerwald > Acked-by: Maxime Ripard Added to togreg branch of iio.git thanks. > --- > drivers/iio/adc/at91_adc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index 3ed94bf..b3ba8af 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -46,7 +46,6 @@ struct at91_adc_state { > struct clk *clk; > bool done; > int irq; > - bool irq_enabled; > u16 last_value; > struct mutex lock; > u8 num_channels; > @@ -85,7 +84,6 @@ static irqreturn_t at91_adc_trigger_handler(int irq, void *p) > buffer->access->store_to(buffer, (u8 *)st->buffer); > > iio_trigger_notify_done(idev->trig); > - st->irq_enabled = true; > > /* Needed to ACK the DRDY interruption */ > at91_adc_readl(st, AT91_ADC_LCDR); > @@ -106,7 +104,6 @@ static irqreturn_t at91_adc_eoc_trigger(int irq, void *private) > > if (iio_buffer_enabled(idev)) { > disable_irq_nosync(irq); > - st->irq_enabled = false; > iio_trigger_poll(idev->trig, iio_get_time_ns()); > } else { > st->last_value = at91_adc_readl(st, AT91_ADC_LCDR); >