From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: Use strict_strtouint instead of kstrtoul
Date: Fri, 19 Oct 2012 16:45:34 +0100 [thread overview]
Message-ID: <5081759E.5040803@kernel.org> (raw)
In-Reply-To: <1350568027-25101-1-git-send-email-lars@metafoo.de>
On 10/18/2012 02:47 PM, Lars-Peter Clausen wrote:
> strict_strto* has been deprecated in favor of kstrto*. Use strict_strtouint
> respective strict_strtoint, since that is what the functions we pass the
> converted values to expect.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Yipped another tunnel, another exciting patch.
It's been a day of delphi, French fish and robots.
Actually this one is definitely worth the churn, thanks!
Added to togreg branch of iio.git
> ---
> drivers/iio/industrialio-buffer.c | 6 +++---
> drivers/iio/industrialio-event.c | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index d4ad374..722a83f 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -371,12 +371,12 @@ ssize_t iio_buffer_write_length(struct device *dev,
> const char *buf,
> size_t len)
> {
> - int ret;
> - ulong val;
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct iio_buffer *buffer = indio_dev->buffer;
> + unsigned int val;
> + int ret;
>
> - ret = strict_strtoul(buf, 10, &val);
> + ret = kstrtouint(buf, 10, &val);
> if (ret)
> return ret;
>
> diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
> index fa6543b..857e630 100644
> --- a/drivers/iio/industrialio-event.c
> +++ b/drivers/iio/industrialio-event.c
> @@ -239,13 +239,13 @@ static ssize_t iio_ev_value_store(struct device *dev,
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
> - unsigned long val;
> + int val;
> int ret;
>
> if (!indio_dev->info->write_event_value)
> return -EINVAL;
>
> - ret = strict_strtoul(buf, 10, &val);
> + ret = kstrtoint(buf, 10, &val);
> if (ret)
> return ret;
>
>
prev parent reply other threads:[~2012-10-19 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 13:47 [PATCH] iio: Use strict_strtouint instead of kstrtoul Lars-Peter Clausen
2012-10-19 15:45 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5081759E.5040803@kernel.org \
--to=jic23@kernel.org \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).