[PATCH] iio: Use strict_strtouint instead of kstrtoul

[PATCH] iio: Use strict_strtouint instead of kstrtoul

[Lars-Peter Clausen]

strict_strto* has been deprecated in favor of kstrto*. Use strict_strtouint
respective strict_strtoint, since that is what the functions we pass the
converted values to expect.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 drivers/iio/industrialio-buffer.c |    6 +++---
 drivers/iio/industrialio-event.c  |    4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
index d4ad374..722a83f 100644
--- a/drivers/iio/industrialio-buffer.c
+++ b/drivers/iio/industrialio-buffer.c
@@ -371,12 +371,12 @@ ssize_t iio_buffer_write_length(struct device *dev,
 				const char *buf,
 				size_t len)
 {
-	int ret;
-	ulong val;
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct iio_buffer *buffer = indio_dev->buffer;
+	unsigned int val;
+	int ret;
 
-	ret = strict_strtoul(buf, 10, &val);
+	ret = kstrtouint(buf, 10, &val);
 	if (ret)
 		return ret;
 
diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
index fa6543b..857e630 100644
--- a/drivers/iio/industrialio-event.c
+++ b/drivers/iio/industrialio-event.c
@@ -239,13 +239,13 @@ static ssize_t iio_ev_value_store(struct device *dev,
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
-	unsigned long val;
+	int val;
 	int ret;
 
 	if (!indio_dev->info->write_event_value)
 		return -EINVAL;
 
-	ret = strict_strtoul(buf, 10, &val);
+	ret = kstrtoint(buf, 10, &val);
 	if (ret)
 		return ret;
 
-- 
1.7.10.4

Re: [PATCH] iio: Use strict_strtouint instead of kstrtoul

[Jonathan Cameron]

On 10/18/2012 02:47 PM, Lars-Peter Clausen wrote:
> strict_strto* has been deprecated in favor of kstrto*. Use strict_strtouint
> respective strict_strtoint, since that is what the functions we pass the
> converted values to expect.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Yipped another tunnel, another exciting patch.
It's been a day of delphi, French fish and robots.

Actually this one is definitely worth the churn, thanks!

Added to togreg branch of iio.git
> ---
>  drivers/iio/industrialio-buffer.c |    6 +++---
>  drivers/iio/industrialio-event.c  |    4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index d4ad374..722a83f 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -371,12 +371,12 @@ ssize_t iio_buffer_write_length(struct device *dev,
>  				const char *buf,
>  				size_t len)
>  {
> -	int ret;
> -	ulong val;
>  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>  	struct iio_buffer *buffer = indio_dev->buffer;
> +	unsigned int val;
> +	int ret;
>  
> -	ret = strict_strtoul(buf, 10, &val);
> +	ret = kstrtouint(buf, 10, &val);
>  	if (ret)
>  		return ret;
>  
> diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
> index fa6543b..857e630 100644
> --- a/drivers/iio/industrialio-event.c
> +++ b/drivers/iio/industrialio-event.c
> @@ -239,13 +239,13 @@ static ssize_t iio_ev_value_store(struct device *dev,
>  {
>  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>  	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
> -	unsigned long val;
> +	int val;
>  	int ret;
>  
>  	if (!indio_dev->info->write_event_value)
>  		return -EINVAL;
>  
> -	ret = strict_strtoul(buf, 10, &val);
> +	ret = kstrtoint(buf, 10, &val);
>  	if (ret)
>  		return ret;
>  
>