From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out-141.synserver.de ([212.40.185.141]:1029 "EHLO smtp-out-137.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933529Ab2JXIZF (ORCPT ); Wed, 24 Oct 2012 04:25:05 -0400 Message-ID: <5087A55C.6010202@metafoo.de> Date: Wed, 24 Oct 2012 10:22:52 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: Dan Carpenter CC: Jonathan Cameron , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] iio:dac:ad5449: unlock on error path References: <20121024071307.GC2536@elgon.mountain> In-Reply-To: <20121024071307.GC2536@elgon.mountain> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 10/24/2012 09:13 AM, Dan Carpenter wrote: > There is an unlock missing on this error path. > > Signed-off-by: Dan Carpenter Thanks, Acked-by: Lars-Peter Clausen > --- > Only needed in linux-next. > > diff --git a/drivers/iio/dac/ad5449.c b/drivers/iio/dac/ad5449.c > index 5b43030..0ee6f8e 100644 > --- a/drivers/iio/dac/ad5449.c > +++ b/drivers/iio/dac/ad5449.c > @@ -124,12 +124,13 @@ static int ad5449_read(struct iio_dev *indio_dev, unsigned int addr, > > ret = spi_sync(st->spi, &msg); > if (ret < 0) > - return ret; > + goto out_unlock; > > *val = be16_to_cpu(st->data[1]); > - mutex_unlock(&indio_dev->mlock); > > - return 0; > +out_unlock: > + mutex_unlock(&indio_dev->mlock); > + return ret; > } > > static int ad5449_read_raw(struct iio_dev *indio_dev, > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html