From: Jonathan Cameron <jic23@kernel.org>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: srinivas pandruvada <srinivas.pandruvada@intel.com>,
Jonathan Cameron <jic23@cam.ac.uk>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: hid-sensors: convert HID_SENSOR_ENUM_BASE_QUIRKS to bool
Date: Wed, 31 Oct 2012 10:35:56 +0000 [thread overview]
Message-ID: <5090FF0C.90204@kernel.org> (raw)
In-Reply-To: <1350892674-4000-1-git-send-email-kirill.shutemov@linux.intel.com>
On 10/22/2012 08:57 AM, Kirill A. Shutemov wrote:
> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
>
> It's non-sense to use tristate for the option, it's bool.
>
Good point.
Applied to fixes-togreg branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
Thanks,
Jonathan
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> drivers/iio/common/hid-sensors/Kconfig | 2 +-
> drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 6 ++----
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/common/hid-sensors/Kconfig b/drivers/iio/common/hid-sensors/Kconfig
> index 8e63d81..ae10778 100644
> --- a/drivers/iio/common/hid-sensors/Kconfig
> +++ b/drivers/iio/common/hid-sensors/Kconfig
> @@ -15,7 +15,7 @@ config HID_SENSOR_IIO_COMMON
> attributes.
>
> config HID_SENSOR_ENUM_BASE_QUIRKS
> - tristate "ENUM base quirks for HID Sensor IIO drivers"
> + bool "ENUM base quirks for HID Sensor IIO drivers"
> depends on HID_SENSOR_IIO_COMMON
> help
> Say yes here to build support for sensor hub FW using
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> index d4b790d..d60198a 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> @@ -36,10 +36,8 @@ static int hid_sensor_data_rdy_trigger_set_state(struct iio_trigger *trig,
> int state_val;
>
> state_val = state ? 1 : 0;
> -#if (defined CONFIG_HID_SENSOR_ENUM_BASE_QUIRKS) || \
> - (defined CONFIG_HID_SENSOR_ENUM_BASE_QUIRKS_MODULE)
> - ++state_val;
> -#endif
> + if (IS_ENABLED(CONFIG_HID_SENSOR_ENUM_BASE_QUIRKS))
> + ++state_val;
> st->data_ready = state;
> sensor_hub_set_feature(st->hsdev, st->power_state.report_id,
> st->power_state.index,
>
prev parent reply other threads:[~2012-10-31 10:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 7:57 [PATCH] iio: hid-sensors: convert HID_SENSOR_ENUM_BASE_QUIRKS to bool Kirill A. Shutemov
2012-10-31 10:35 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5090FF0C.90204@kernel.org \
--to=jic23@kernel.org \
--cc=jic23@cam.ac.uk \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).