From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
linux-iio@vger.kernel.org, drivers@analog.com
Subject: Re: [PATCH 1/7] iio:imu:adis: Add debugfs register access support
Date: Tue, 20 Nov 2012 19:51:10 +0000 [thread overview]
Message-ID: <50ABDF2E.10100@kernel.org> (raw)
In-Reply-To: <1353418611-17614-1-git-send-email-lars@metafoo.de>
On 11/20/2012 01:36 PM, Lars-Peter Clausen wrote:
> Provide a IIO debugfs register access function for the ADIS library. This
> function can be used by induvidual drivers to allow raw register access via
> debugfs.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
added to togreg branch of iio.git
> ---
> drivers/iio/imu/adis.c | 23 +++++++++++++++++++++++
> include/linux/iio/imu/adis.h | 11 +++++++++++
> 2 files changed, 34 insertions(+)
>
> diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
> index 8259b77..28d4df2 100644
> --- a/drivers/iio/imu/adis.c
> +++ b/drivers/iio/imu/adis.c
> @@ -135,6 +135,29 @@ error_ret:
> }
> EXPORT_SYMBOL_GPL(adis_read_reg_16);
>
> +#ifdef CONFIG_DEBUG_FS
> +
> +int adis_debugfs_reg_access(struct iio_dev *indio_dev,
> + unsigned int reg, unsigned int writeval, unsigned int *readval)
> +{
> + struct adis *adis = iio_device_get_drvdata(indio_dev);
> +
> + if (readval) {
> + uint16_t val16;
> + int ret;
> +
> + ret = adis_read_reg_16(adis, reg, &val16);
> + *readval = val16;
> +
> + return ret;
> + } else {
> + return adis_write_reg_16(adis, reg, writeval);
> + }
> +}
> +EXPORT_SYMBOL(adis_debugfs_reg_access);
> +
> +#endif
> +
> /**
> * adis_enable_irq() - Enable or disable data ready IRQ
> * @adis: The adis device
> diff --git a/include/linux/iio/imu/adis.h b/include/linux/iio/imu/adis.h
> index 8c3304d..fce7bc3 100644
> --- a/include/linux/iio/imu/adis.h
> +++ b/include/linux/iio/imu/adis.h
> @@ -183,4 +183,15 @@ static inline void adis_remove_trigger(struct adis *adis)
>
> #endif /* CONFIG_IIO_BUFFER */
>
> +#ifdef CONFIG_DEBUG_FS
> +
> +int adis_debugfs_reg_access(struct iio_dev *indio_dev,
> + unsigned int reg, unsigned int writeval, unsigned int *readval);
> +
> +#else
> +
> +#define adis_debugfs_reg_access NULL
> +
> +#endif
> +
> #endif
>
prev parent reply other threads:[~2012-11-20 19:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 13:36 [PATCH 1/7] iio:imu:adis: Add debugfs register access support Lars-Peter Clausen
2012-11-20 13:36 ` [PATCH 2/7] iio:imu:adis: Add support for 32bit registers Lars-Peter Clausen
2012-11-20 20:55 ` Jonathan Cameron
2012-11-20 13:36 ` [PATCH 3/7] iio:gyro: Add support for the ADIS16136 gyroscope Lars-Peter Clausen
2012-11-20 21:05 ` Jonathan Cameron
2012-11-20 21:15 ` Lars-Peter Clausen
2012-11-20 21:26 ` Jonathan Cameron
2012-11-20 13:36 ` [PATCH 4/7] iio:imu:adis: Add paging support Lars-Peter Clausen
2012-11-20 21:10 ` Jonathan Cameron
2012-11-20 13:36 ` [PATCH 5/7] iio: Add pressure channel type Lars-Peter Clausen
2012-11-20 21:12 ` Jonathan Cameron
2012-11-20 13:36 ` [PATCH 6/7] iio: Factor out fixed point number parsing into its own function Lars-Peter Clausen
2012-11-20 21:14 ` Jonathan Cameron
2012-11-20 13:36 ` [PATCH 7/7] iio:imu: Add support for the ADIS16480 and similar IMUs Lars-Peter Clausen
2012-11-20 21:24 ` Jonathan Cameron
2012-11-20 19:51 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ABDF2E.10100@kernel.org \
--to=jic23@kernel.org \
--cc=drivers@analog.com \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).