* [PATCH] staging:iio:adis16260: Select adislib
[not found] <50bda6c1.YyzaM05r7Y5H3Jeo%fengguang.wu@intel.com>
@ 2012-12-06 13:48 ` Lars-Peter Clausen
2012-12-08 9:53 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2012-12-06 13:48 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: fengguang.wu, linux-iio, Lars-Peter Clausen
Commit 9d5e9fdf ("staging:iio:adis16260: Use adis library") switched over the
adis16260 driver to use the common adis library but neglected to update the
Kconfig entry to reflect the change.
This leads to the following compile error if no other driver selects the adis
library:
drivers/built-in.o: In function `adis16260_write_frequency':
adis16260_core.c:(.text+0x5a83bf): undefined reference to `adis_write_reg_8'
drivers/built-in.o: In function `adis16260_read_frequency':
adis16260_core.c:(.text+0x5a8433): undefined reference to `adis_read_reg_16'
drivers/built-in.o: In function `adis16260_write_raw':
adis16260_core.c:(.text+0x5a8538): undefined reference to `adis_write_reg_16'
adis16260_core.c:(.text+0x5a856b): undefined reference to `adis_write_reg_16'
drivers/built-in.o: In function `adis16260_read_raw':
adis16260_core.c:(.text+0x5a85d3): undefined reference to `adis_single_conversion'
adis16260_core.c:(.text+0x5a873e): undefined reference to `adis_read_reg_16'
adis16260_core.c:(.text+0x5a87fb): undefined reference to `adis_read_reg_16'
drivers/built-in.o: In function `adis16260_probe':
adis16260_core.c:(.devinit.text+0x5c6b8): undefined reference to `adis_init'
adis16260_core.c:(.devinit.text+0x5c799): undefined reference to `adis_initial_startup'
drivers/built-in.o: In function `adis16260_remove':
adis16260_core.c:(.devexit.text+0x9943): undefined reference to `adis_write_reg_16'
This patch updates the adis16260 Kconfig entry to select the adis library.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/staging/iio/gyro/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/gyro/Kconfig b/drivers/staging/iio/gyro/Kconfig
index ea295b2..87979a0 100644
--- a/drivers/staging/iio/gyro/Kconfig
+++ b/drivers/staging/iio/gyro/Kconfig
@@ -27,8 +27,8 @@ config ADIS16130
config ADIS16260
tristate "Analog Devices ADIS16260 Digital Gyroscope Sensor SPI driver"
depends on SPI
- select IIO_TRIGGER if IIO_BUFFER
- select IIO_SW_RING if IIO_BUFFER
+ select IIO_ADIS_LIB
+ select IIO_ADIS_LIB_BUFFER if IIO_BUFFER
help
Say yes here to build support for Analog Devices ADIS16260 ADIS16265
ADIS16250 ADIS16255 and ADIS16251 programmable digital gyroscope sensors.
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging:iio:adis16260: Select adislib
2012-12-06 13:48 ` [PATCH] staging:iio:adis16260: Select adislib Lars-Peter Clausen
@ 2012-12-08 9:53 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2012-12-08 9:53 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: Jonathan Cameron, fengguang.wu, linux-iio
On 12/06/2012 01:48 PM, Lars-Peter Clausen wrote:
> Commit 9d5e9fdf ("staging:iio:adis16260: Use adis library") switched over the
> adis16260 driver to use the common adis library but neglected to update the
> Kconfig entry to reflect the change.
>
> This leads to the following compile error if no other driver selects the adis
> library:
>
> drivers/built-in.o: In function `adis16260_write_frequency':
> adis16260_core.c:(.text+0x5a83bf): undefined reference to `adis_write_reg_8'
> drivers/built-in.o: In function `adis16260_read_frequency':
> adis16260_core.c:(.text+0x5a8433): undefined reference to `adis_read_reg_16'
> drivers/built-in.o: In function `adis16260_write_raw':
> adis16260_core.c:(.text+0x5a8538): undefined reference to `adis_write_reg_16'
> adis16260_core.c:(.text+0x5a856b): undefined reference to `adis_write_reg_16'
> drivers/built-in.o: In function `adis16260_read_raw':
> adis16260_core.c:(.text+0x5a85d3): undefined reference to `adis_single_conversion'
> adis16260_core.c:(.text+0x5a873e): undefined reference to `adis_read_reg_16'
> adis16260_core.c:(.text+0x5a87fb): undefined reference to `adis_read_reg_16'
> drivers/built-in.o: In function `adis16260_probe':
> adis16260_core.c:(.devinit.text+0x5c6b8): undefined reference to `adis_init'
> adis16260_core.c:(.devinit.text+0x5c799): undefined reference to `adis_initial_startup'
> drivers/built-in.o: In function `adis16260_remove':
> adis16260_core.c:(.devexit.text+0x9943): undefined reference to `adis_write_reg_16'
>
> This patch updates the adis16260 Kconfig entry to select the adis library.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Added to fixes-togreg branch of iio.git
Will hold these until post merge window.
> ---
> drivers/staging/iio/gyro/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/gyro/Kconfig b/drivers/staging/iio/gyro/Kconfig
> index ea295b2..87979a0 100644
> --- a/drivers/staging/iio/gyro/Kconfig
> +++ b/drivers/staging/iio/gyro/Kconfig
> @@ -27,8 +27,8 @@ config ADIS16130
> config ADIS16260
> tristate "Analog Devices ADIS16260 Digital Gyroscope Sensor SPI driver"
> depends on SPI
> - select IIO_TRIGGER if IIO_BUFFER
> - select IIO_SW_RING if IIO_BUFFER
> + select IIO_ADIS_LIB
> + select IIO_ADIS_LIB_BUFFER if IIO_BUFFER
> help
> Say yes here to build support for Analog Devices ADIS16260 ADIS16265
> ADIS16250 ADIS16255 and ADIS16251 programmable digital gyroscope sensors.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-08 9:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <50bda6c1.YyzaM05r7Y5H3Jeo%fengguang.wu@intel.com>
2012-12-06 13:48 ` [PATCH] staging:iio:adis16260: Select adislib Lars-Peter Clausen
2012-12-08 9:53 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).