From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
linux-iio@vger.kernel.org,
Michael Hennerich <michael.hennerich@analog.com>
Subject: Re: [PATCH] iio:adf4350: Fix typo
Date: Sat, 08 Dec 2012 09:53:33 +0000 [thread overview]
Message-ID: <50C30E1D.40708@kernel.org> (raw)
In-Reply-To: <1354810171-18780-1-git-send-email-lars@metafoo.de>
On 12/06/2012 04:09 PM, Lars-Peter Clausen wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> There is a typo in the adf4350 driver turning a shift into a compare. This patch
> fixes it.
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
added to fixes-togreg branch of iio.git
> ---
> drivers/iio/frequency/adf4350.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/frequency/adf4350.c b/drivers/iio/frequency/adf4350.c
> index e35bb8f..c7de8b5 100644
> --- a/drivers/iio/frequency/adf4350.c
> +++ b/drivers/iio/frequency/adf4350.c
> @@ -173,7 +173,7 @@ static int adf4350_set_freq(struct adf4350_state *st, unsigned long long freq)
> } while ((st->r1_mod > ADF4350_MAX_MODULUS) && r_cnt);
> } while (r_cnt == 0);
>
> - tmp = freq * (u64)st->r1_mod + (st->fpfd > 1);
> + tmp = freq * (u64)st->r1_mod + (st->fpfd >> 1);
> do_div(tmp, st->fpfd); /* Div round closest (n + d/2)/d */
> st->r0_fract = do_div(tmp, st->r1_mod);
> st->r0_int = tmp;
>
prev parent reply other threads:[~2012-12-08 9:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 16:09 [PATCH] iio:adf4350: Fix typo Lars-Peter Clausen
2012-12-08 9:53 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C30E1D.40708@kernel.org \
--to=jic23@kernel.org \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).