From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailhost.informatik.uni-hamburg.de ([134.100.9.70]:64200 "EHLO mailhost.informatik.uni-hamburg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823Ab2LJVia (ORCPT ); Mon, 10 Dec 2012 16:38:30 -0500 Message-ID: <50C6567D.7080303@metafoo.de> Date: Mon, 10 Dec 2012 22:39:09 +0100 From: Lars-Peter Clausen MIME-Version: 1.0 To: Alexander Holler CC: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Jonathan Cameron , rtc-linux@googlegroups.com, Alessandro Zummo , srinivas pandruvada Subject: Re: [PATCH 3/3 v2] iio: add rtc-driver for HID sensors of type time References: <50C5DFCC.60203@ahsoftware.de> <1355151119-2489-1-git-send-email-holler@ahsoftware.de> <50C61675.2000407@metafoo.de> <50C63BBD.3080202@ahsoftware.de> <50C64484.4060306@metafoo.de> <50C65381.8010609@ahsoftware.de> In-Reply-To: <50C65381.8010609@ahsoftware.de> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 12/10/2012 10:26 PM, Alexander Holler wrote: > Am 10.12.2012 21:22, schrieb Lars-Peter Clausen: >> On 12/10/2012 08:45 PM, Alexander Holler wrote: >>> Am 10.12.2012 18:05, schrieb Lars-Peter Clausen: >>> >>>> Looks pretty good now. But there are still some IIO remnants which should be >>>> removed as well. Also the driver should move to drivers/rtc/ since, well, >>>> it's a rtc driver not a IIO driver. >>> >>> I think it still should be stick to iio, because that is where all HID >>> sensors currently are found and where the user would expect to find such >>> a driver. >> >> That's because all the current IIO sensor drivers fall in the IIO domain. This >> one clearly is a RTC driver, so it belongs in drivers/rtc/ > > Where nobody will find it if he searches for drivers for his HID sensor. > I still see it as HID sensor driver and not a rtc-driver. > But ... I can understand your position, but drivers are usually grouped by function not by topology. If there is a proper Kconfig help text people should hopefully be find it. > >> >>> >>>>> +/* Channel definitions */ >>>>> +static const struct iio_chan_spec hid_time_channels[TIME_RTC_CHANNEL_MAX] = { >>> >>> And that is imho the last remaining iio-stuff. If necessary I can remove >>> it too. >> >> That and the remaining bits of the read_raw callback. > > Ok. I will make a v3. > Btw. have you seen the other comments I had inline in my response to your v2?