From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out-011.synserver.de ([212.40.185.11]:1115 "EHLO smtp-out-237.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755209Ab2LNJ5A (ORCPT ); Fri, 14 Dec 2012 04:57:00 -0500 Message-ID: <50CAF7E9.7000905@metafoo.de> Date: Fri, 14 Dec 2012 10:56:57 +0100 From: Lars-Peter Clausen MIME-Version: 1.0 To: Axel Lin CC: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, "Hennerich, Michael" Subject: Re: [PATCH 1/6] iio: adc: ad7266: Don't set error code to st->vref_uv References: <1355471245.11297.1.camel@phoenix> In-Reply-To: <1355471245.11297.1.camel@phoenix> Content-Type: text/plain; charset=UTF-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 12/14/2012 08:47 AM, Axel Lin wrote: > regulator_get_voltage() may return negative error code. > Add error checking to avoid setting error code to st->vref_uv. > > Signed-off-by: Axel Lin Thanks Axel, for the whole series: Acked-by: Lars-Peter Clausen > --- > drivers/iio/adc/ad7266.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c > index a6f4fc5..e36107d 100644 > --- a/drivers/iio/adc/ad7266.c > +++ b/drivers/iio/adc/ad7266.c > @@ -411,7 +411,11 @@ static int __devinit ad7266_probe(struct spi_device *spi) > if (ret) > goto error_put_reg; > > - st->vref_uv = regulator_get_voltage(st->reg); > + ret = regulator_get_voltage(st->reg); > + if (ret < 0) > + goto error_disable_reg; > + > + st->vref_uv = ret; > } else { > /* Use internal reference */ > st->vref_uv = 2500000;