From: Jonathan Cameron <jic23@kernel.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
Michael Hennerich <hennerich@blackfin.uclinux.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: dac: ad5446: Don't set error code to voltage_uv
Date: Tue, 18 Dec 2012 19:23:09 +0000 [thread overview]
Message-ID: <50D0C29D.3030209@kernel.org> (raw)
In-Reply-To: <1355801617.11880.1.camel@phoenix>
On 12/18/2012 03:33 AM, Axel Lin wrote:
> regulator_get_voltage() may return negative error code.
> Add error checking to avoid setting error code to voltage_uv.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
added to fixes-togreg branch of iio.git
> ---
> Sorry. Just found I made the same mistake again.
> Here is v2, should check if ret is negative value.
> drivers/iio/dac/ad5446.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
> index 3310cbb..607378f 100644
> --- a/drivers/iio/dac/ad5446.c
> +++ b/drivers/iio/dac/ad5446.c
> @@ -226,7 +226,11 @@ static int __devinit ad5446_probe(struct device *dev, const char *name,
> if (ret)
> goto error_put_reg;
>
> - voltage_uv = regulator_get_voltage(reg);
> + ret = regulator_get_voltage(reg);
> + if (ret < 0)
> + goto error_disable_reg;
> +
> + voltage_uv = ret;
> }
>
> indio_dev = iio_device_alloc(sizeof(*st));
>
prev parent reply other threads:[~2012-12-18 19:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 3:33 [PATCH v2] iio: dac: ad5446: Don't set error code to voltage_uv Axel Lin
2012-12-18 19:23 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D0C29D.3030209@kernel.org \
--to=jic23@kernel.org \
--cc=axel.lin@ingics.com \
--cc=hennerich@blackfin.uclinux.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).