From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:39617 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752046Ab2L0LZR (ORCPT ); Thu, 27 Dec 2012 06:25:17 -0500 Message-ID: <50DC301A.4040103@kernel.org> Date: Thu, 27 Dec 2012 11:25:14 +0000 From: Jonathan Cameron MIME-Version: 1.0 To: Marek Vasut CC: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabio Estevam , Shawn Guo Subject: Re: [PATCH 1/3 V2] iio: mxs: Remove unused struct mxs_lradc_chan References: <1355449598-15980-1-git-send-email-marex@denx.de> In-Reply-To: <1355449598-15980-1-git-send-email-marex@denx.de> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 12/14/2012 01:46 AM, Marek Vasut wrote: > This structure definition seems to be some kind of remnant from > previous development that accidentally made it mainline. Remove > it as it's unused. > > Remove unused "enable" field from struct mxs_lradc as well. This > seems to be remnant of early development too. > Added to togreg branch of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git Jonathan > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Jonathan Cameron > Cc: Shawn Guo > --- > drivers/staging/iio/adc/mxs-lradc.c | 7 ------- > 1 file changed, 7 deletions(-) > > V2: The patch is now combination of previously two separate patches: > [PATCH 1/4] iio: mxs: Remove unused struct mxs_lradc_chan > [PATCH 2/4] iio: mxs: Remove unused fields from mxs_lradc > > diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c > index ca7c1fa..6249957 100644 > --- a/drivers/staging/iio/adc/mxs-lradc.c > +++ b/drivers/staging/iio/adc/mxs-lradc.c > @@ -75,11 +75,6 @@ static const char * const mxs_lradc_irq_name[] = { > "mxs-lradc-button1", > }; > > -struct mxs_lradc_chan { > - uint8_t slot; > - uint8_t flags; > -}; > - > struct mxs_lradc { > struct device *dev; > void __iomem *base; > @@ -90,8 +85,6 @@ struct mxs_lradc { > > struct mutex lock; > > - uint8_t enable; > - > struct completion completion; > }; > >