linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: max1363 comment and whitespace fixes
Date: Tue, 01 Jan 2013 17:43:37 +0000	[thread overview]
Message-ID: <50E32049.8040508@kernel.org> (raw)
In-Reply-To: <1356910018-14422-2-git-send-email-pmeerw@pmeerw.net>

On 12/30/2012 11:26 PM, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Applied to togreg branch of iio.git

Thanks,
> ---
>  drivers/iio/adc/max1363.c |   15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
> index 46d8365..0ba4fea 100644
> --- a/drivers/iio/adc/max1363.c
> +++ b/drivers/iio/adc/max1363.c
> @@ -56,7 +56,7 @@
>  #define MAX1363_SETUP_POWER_UP_INT_REF		0x10
>  #define MAX1363_SETUP_POWER_DOWN_INT_REF	0x00
>  
> -/* think about includeing max11600 etc - more settings */
> +/* think about including max11600 etc - more settings */
>  #define MAX1363_SETUP_EXT_CLOCK			0x08
>  #define MAX1363_SETUP_INT_CLOCK			0x00
>  #define MAX1363_SETUP_UNIPOLAR			0x00
> @@ -87,7 +87,7 @@
>  /* max123{6-9} only */
>  #define MAX1236_SCAN_MID_TO_CHANNEL		0x40
>  
> -/* max1363 only - merely part of channel selects or don't care for others*/
> +/* max1363 only - merely part of channel selects or don't care for others */
>  #define MAX1363_CONFIG_EN_MON_MODE_READ 0x18
>  
>  #define MAX1363_CHANNEL_SEL(a) ((a) << 1)
> @@ -134,7 +134,7 @@ enum max1363_modes {
>   * @mode_list:		array of available scan modes
>   * @default_mode:	the scan mode in which the chip starts up
>   * @int_vref_mv:	the internal reference voltage
> - * @num_channels:	number of channels
> + * @num_modes:		number of modes
>   * @bits:		accuracy of the adc in bits
>   */
>  struct max1363_chip_info {
> @@ -153,7 +153,7 @@ struct max1363_chip_info {
>   * @client:		i2c_client
>   * @setupbyte:		cache of current device setup byte
>   * @configbyte:		cache of current device config byte
> - * @chip_info:		chip model specific constants, available modes etc
> + * @chip_info:		chip model specific constants, available modes, etc.
>   * @current_mode:	the scan mode of this chip
>   * @requestedmask:	a valid requested set of channels
>   * @reg:		supply regulator
> @@ -294,7 +294,7 @@ static const struct max1363_mode max1363_mode_table[] = {
>  
>  static const struct max1363_mode
>  *max1363_match_mode(const unsigned long *mask,
> -const struct max1363_chip_info *ci)
> +	const struct max1363_chip_info *ci)
>  {
>  	int i;
>  	if (mask)
> @@ -1395,7 +1395,7 @@ static int max1363_initial_setup(struct max1363_state *st)
>  		| MAX1363_SETUP_UNIPOLAR
>  		| MAX1363_SETUP_NORESET;
>  
> -	/* Set scan mode writes the config anyway so wait until then*/
> +	/* Set scan mode writes the config anyway so wait until then */
>  	st->setupbyte = MAX1363_SETUP_BYTE(st->setupbyte);
>  	st->current_mode = &max1363_mode_table[st->chip_info->default_mode];
>  	st->configbyte = MAX1363_CONFIG_BYTE(st->configbyte);
> @@ -1424,7 +1424,6 @@ static int __devinit max1363_alloc_scan_masks(struct iio_dev *indio_dev)
>  	return 0;
>  }
>  
> -
>  static irqreturn_t max1363_trigger_handler(int irq, void *p)
>  {
>  	struct iio_poll_func *pf = p;
> @@ -1523,7 +1522,7 @@ static int __devinit max1363_probe(struct i2c_client *client,
>  	if (ret)
>  		goto error_disable_reg;
>  
> -	/* Estabilish that the iio_dev is a child of the i2c device */
> +	/* Establish that the iio_dev is a child of the i2c device */
>  	indio_dev->dev.parent = &client->dev;
>  	indio_dev->name = id->name;
>  	indio_dev->channels = st->chip_info->channels;
> 

  reply	other threads:[~2013-01-01 17:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-30 23:26 [PATCH 1/2] iio: cleanup buffer setup code in max1363 driver Peter Meerwald
2012-12-30 23:26 ` [PATCH 2/2] iio: max1363 comment and whitespace fixes Peter Meerwald
2013-01-01 17:43   ` Jonathan Cameron [this message]
2013-01-01 17:42 ` [PATCH 1/2] iio: cleanup buffer setup code in max1363 driver Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E32049.8040508@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).