From: Jonathan Cameron <jic23@kernel.org>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] iio: lp8788_adc: fix a parent device in _probe()
Date: Sun, 06 Jan 2013 11:38:05 +0000 [thread overview]
Message-ID: <50E9621D.9000003@kernel.org> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F69E10FCB@DQHE02.ent.ti.com>
On 01/03/2013 06:28 AM, Kim, Milo wrote:
> The lp8788-adc is a platform driver of lp8788-mfd.
> The platform device is allocated when mfd_add_devices() is called
> in lp8788-mfd.
> On the other hand, 'lp->dev' is the i2c client device.
>
> Therefore, this 'platform_device' is a proper parent device of
> iio device and device kernel message.
Added to togreg branch of iio.git
Thanks,
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> ---
> drivers/iio/adc/lp8788_adc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/lp8788_adc.c b/drivers/iio/adc/lp8788_adc.c
> index 72955e4..4c9b0f7 100644
> --- a/drivers/iio/adc/lp8788_adc.c
> +++ b/drivers/iio/adc/lp8788_adc.c
> @@ -214,7 +214,7 @@ static int lp8788_adc_probe(struct platform_device *pdev)
>
> mutex_init(&adc->lock);
>
> - indio_dev->dev.parent = lp->dev;
> + indio_dev->dev.parent = &pdev->dev;
> indio_dev->name = pdev->name;
> indio_dev->modes = INDIO_DIRECT_MODE;
> indio_dev->info = &lp8788_adc_info;
> @@ -223,7 +223,7 @@ static int lp8788_adc_probe(struct platform_device *pdev)
>
> ret = iio_device_register(indio_dev);
> if (ret) {
> - dev_err(lp->dev, "iio dev register err: %d\n", ret);
> + dev_err(&pdev->dev, "iio dev register err: %d\n", ret);
> goto err_iio_device;
> }
>
>
prev parent reply other threads:[~2013-01-06 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 6:28 [PATCH 1/2] iio: lp8788_adc: fix a parent device in _probe() Kim, Milo
2013-01-06 11:38 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E9621D.9000003@kernel.org \
--to=jic23@kernel.org \
--cc=Milo.Kim@ti.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).