* [PATCH 1/2] iio: lp8788_adc: fix a parent device in _probe()
@ 2013-01-03 6:28 Kim, Milo
2013-01-06 11:38 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Kim, Milo @ 2013-01-03 6:28 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
The lp8788-adc is a platform driver of lp8788-mfd.
The platform device is allocated when mfd_add_devices() is called
in lp8788-mfd.
On the other hand, 'lp->dev' is the i2c client device.
Therefore, this 'platform_device' is a proper parent device of
iio device and device kernel message.
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
drivers/iio/adc/lp8788_adc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/lp8788_adc.c b/drivers/iio/adc/lp8788_adc.c
index 72955e4..4c9b0f7 100644
--- a/drivers/iio/adc/lp8788_adc.c
+++ b/drivers/iio/adc/lp8788_adc.c
@@ -214,7 +214,7 @@ static int lp8788_adc_probe(struct platform_device *pdev)
mutex_init(&adc->lock);
- indio_dev->dev.parent = lp->dev;
+ indio_dev->dev.parent = &pdev->dev;
indio_dev->name = pdev->name;
indio_dev->modes = INDIO_DIRECT_MODE;
indio_dev->info = &lp8788_adc_info;
@@ -223,7 +223,7 @@ static int lp8788_adc_probe(struct platform_device *pdev)
ret = iio_device_register(indio_dev);
if (ret) {
- dev_err(lp->dev, "iio dev register err: %d\n", ret);
+ dev_err(&pdev->dev, "iio dev register err: %d\n", ret);
goto err_iio_device;
}
--
1.7.9.5
Best Regards,
Milo
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/2] iio: lp8788_adc: fix a parent device in _probe()
2013-01-03 6:28 [PATCH 1/2] iio: lp8788_adc: fix a parent device in _probe() Kim, Milo
@ 2013-01-06 11:38 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2013-01-06 11:38 UTC (permalink / raw)
To: Kim, Milo
Cc: Jonathan Cameron, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
On 01/03/2013 06:28 AM, Kim, Milo wrote:
> The lp8788-adc is a platform driver of lp8788-mfd.
> The platform device is allocated when mfd_add_devices() is called
> in lp8788-mfd.
> On the other hand, 'lp->dev' is the i2c client device.
>
> Therefore, this 'platform_device' is a proper parent device of
> iio device and device kernel message.
Added to togreg branch of iio.git
Thanks,
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> ---
> drivers/iio/adc/lp8788_adc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/lp8788_adc.c b/drivers/iio/adc/lp8788_adc.c
> index 72955e4..4c9b0f7 100644
> --- a/drivers/iio/adc/lp8788_adc.c
> +++ b/drivers/iio/adc/lp8788_adc.c
> @@ -214,7 +214,7 @@ static int lp8788_adc_probe(struct platform_device *pdev)
>
> mutex_init(&adc->lock);
>
> - indio_dev->dev.parent = lp->dev;
> + indio_dev->dev.parent = &pdev->dev;
> indio_dev->name = pdev->name;
> indio_dev->modes = INDIO_DIRECT_MODE;
> indio_dev->info = &lp8788_adc_info;
> @@ -223,7 +223,7 @@ static int lp8788_adc_probe(struct platform_device *pdev)
>
> ret = iio_device_register(indio_dev);
> if (ret) {
> - dev_err(lp->dev, "iio dev register err: %d\n", ret);
> + dev_err(&pdev->dev, "iio dev register err: %d\n", ret);
> goto err_iio_device;
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-06 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-03 6:28 [PATCH 1/2] iio: lp8788_adc: fix a parent device in _probe() Kim, Milo
2013-01-06 11:38 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).