* [PATCH] iio: fix Kconfig for max1363
[not found] <20130110101642.GA18411@localhost>
@ 2013-01-10 17:29 ` Peter Meerwald
2013-01-12 20:54 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Peter Meerwald @ 2013-01-10 17:29 UTC (permalink / raw)
To: linux-iio; +Cc: jic23, Peter Meerwald, Fengguang Wu
ERROR: "iio_triggered_buffer_setup" [drivers/iio/adc/max1363.ko] undefined!
ERROR: "iio_triggered_buffer_cleanup" [drivers/iio/adc/max1363.ko] undefined!
add select IIO_TRIGGERED_BUFFER
IIO_TRIGGERED_BUFFER in turn selects IIO_TRIGGER and IIO_KFIFO_BUF, so drop those
MAX1363_RING_BUFFER is not used anymore
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Fengguang Wu <fengguang.wu@intel.com>
---
drivers/iio/adc/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index fe822a1..e372257 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -100,10 +100,8 @@ config LP8788_ADC
config MAX1363
tristate "Maxim max1363 ADC driver"
depends on I2C
- select IIO_TRIGGER
- select MAX1363_RING_BUFFER
select IIO_BUFFER
- select IIO_KFIFO_BUF
+ select IIO_TRIGGERED_BUFFER
help
Say yes here to build support for many Maxim i2c analog to digital
converters (ADC). (max1361, max1362, max1363, max1364, max1036,
--
1.8.0.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: fix Kconfig for max1363
2013-01-10 17:29 ` [PATCH] iio: fix Kconfig for max1363 Peter Meerwald
@ 2013-01-12 20:54 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2013-01-12 20:54 UTC (permalink / raw)
To: Peter Meerwald; +Cc: linux-iio, Fengguang Wu
On 01/10/2013 05:29 PM, Peter Meerwald wrote:
> ERROR: "iio_triggered_buffer_setup" [drivers/iio/adc/max1363.ko] undefined!
> ERROR: "iio_triggered_buffer_cleanup" [drivers/iio/adc/max1363.ko] undefined!
>
> add select IIO_TRIGGERED_BUFFER
>
> IIO_TRIGGERED_BUFFER in turn selects IIO_TRIGGER and IIO_KFIFO_BUF, so drop those
> MAX1363_RING_BUFFER is not used anymore
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Fengguang Wu <fengguang.wu@intel.com>
Thanks,
Have added a reported by tag for Fengguang Wu and added to togreg branch of
iio.git
> ---
> drivers/iio/adc/Kconfig | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index fe822a1..e372257 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -100,10 +100,8 @@ config LP8788_ADC
> config MAX1363
> tristate "Maxim max1363 ADC driver"
> depends on I2C
> - select IIO_TRIGGER
> - select MAX1363_RING_BUFFER
> select IIO_BUFFER
> - select IIO_KFIFO_BUF
> + select IIO_TRIGGERED_BUFFER
> help
> Say yes here to build support for many Maxim i2c analog to digital
> converters (ADC). (max1361, max1362, max1363, max1364, max1036,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-12 20:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20130110101642.GA18411@localhost>
2013-01-10 17:29 ` [PATCH] iio: fix Kconfig for max1363 Peter Meerwald
2013-01-12 20:54 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).