From: Jonathan Cameron <jic23@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, jbrenner@taosinc.com
Subject: Re: [PATCH 0/3 V2] staging:iio:tsl2583 update interfaces
Date: Sun, 20 Jan 2013 12:10:48 +0000 [thread overview]
Message-ID: <50FBDEC8.1040703@kernel.org> (raw)
In-Reply-To: <1357987339-11800-1-git-send-email-jic23@kernel.org>
Jon,
Any chance you could have a look at these? No particular
rush though...
Jonathan
On 01/12/2013 10:42 AM, Jonathan Cameron wrote:
> Final patch fixed so it doesn't contain a typo that prevents it compiling.
> Sorry about that.
>
> This driver is now fairly old and has lagged a bit as we have brought
> in newer cleaner ways of doing things. Anyhow, I was looking at
> it with a view to moving it out of staging and thought I would clean
> up a few bits whilst doing so. Note I don't have one of these.
>
> There are some 'unusual' interfaces in here still such as integrationtime.
> We need to have a think about whether we want to add these to the info
> mask and handle them through read/write_raw or not.
>
> I'm also decidely unkeen on the manual power enable / disable that is
> still in this driver. That should ideally be done on demand.
>
> Hence i am not proposing moving this out of staging just yet!
>
> Jonathan
>
> Jonathan Cameron (3):
> staging:iio:light:tsl2583 use read_raw, write_raw hooks.
> staging:iio:light:tsl2583 apply in_ prefix to attributes.
> staging:iio:light:tsl2583 switch to kstrto and strtobool
>
> drivers/staging/iio/light/tsl2583.c | 247 +++++++++++++++++-------------------
> 1 file changed, 119 insertions(+), 128 deletions(-)
>
prev parent reply other threads:[~2013-01-20 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 10:42 [PATCH 0/3 V2] staging:iio:tsl2583 update interfaces Jonathan Cameron
2013-01-12 10:42 ` [PATCH 1/3] staging:iio:light:tsl2583 use read_raw, write_raw hooks Jonathan Cameron
2013-01-12 10:42 ` [PATCH 2/3] staging:iio:light:tsl2583 apply in_ prefix to attributes Jonathan Cameron
2013-01-12 10:42 ` [PATCH 3/3] staging:iio:light:tsl2583 switch to kstrto and strtobool Jonathan Cameron
2013-01-20 12:10 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FBDEC8.1040703@kernel.org \
--to=jic23@kernel.org \
--cc=jbrenner@taosinc.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).