From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:57022 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750956AbdAONzi (ORCPT ); Sun, 15 Jan 2017 08:55:38 -0500 Subject: Re: [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref" To: David Lechner , devicetree@vger.kernel.org, linux-iio@vger.kernel.org References: <1484157171-15571-1-git-send-email-david@lechnology.com> <1484157171-15571-4-git-send-email-david@lechnology.com> <47d15fe8-85c5-6e1c-cd89-71398ad79def@kernel.org> Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: <50e4cbe0-2dd4-53cf-f696-b8a9c6ec3d9d@kernel.org> Date: Sun, 15 Jan 2017 13:55:37 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 14/01/17 18:09, David Lechner wrote: > On 01/14/2017 06:52 AM, Jonathan Cameron wrote: >> On 11/01/17 17:52, David Lechner wrote: >>> This changes the reference voltage regulator matching string from "refin" >>> to "vref". This is to be consistent with other A/DC chips that also use >>> "vref-supply" in their device tree bindings. >>> >>> Signed-off-by: David Lechner >>> --- >>> drivers/iio/adc/ti-ads7950.c | 6 +++--- >> Again, we missed this before and it would have been nice to have >> had it as vref (which is matches the datasheet). The question >> becomes how do we handle this going forward with no risk of breaking >> existing device trees. We may have to do an optional get on one >> name and then a non optional on the second. It's ugly, but >> would fix this up in a 'safe' way. >> > > Again, I don't think it is too late since this driver only exists in the iio/testing branch. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > >> Jonathan >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c >>> index b587fa6..16a0663 100644 >>> --- a/drivers/iio/adc/ti-ads7950.c >>> +++ b/drivers/iio/adc/ti-ads7950.c >>> @@ -411,15 +411,15 @@ static int ti_ads7950_probe(struct spi_device *spi) >>> spi_message_init_with_transfers(&st->scan_single_msg, >>> st->scan_single_xfer, 3); >>> >>> - st->reg = devm_regulator_get(&spi->dev, "refin"); >>> + st->reg = devm_regulator_get(&spi->dev, "vref"); >>> if (IS_ERR(st->reg)) { >>> - dev_err(&spi->dev, "Failed get get regulator \"refin\"\n"); >>> + dev_err(&spi->dev, "Failed get get regulator \"vref\"\n"); >>> return PTR_ERR(st->reg); >>> } >>> >>> ret = regulator_enable(st->reg); >>> if (ret) { >>> - dev_err(&spi->dev, "Failed to enable regulator \"refin\"\n"); >>> + dev_err(&spi->dev, "Failed to enable regulator \"vref\"\n"); >>> return ret; >>> } >>> >>> >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html