From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, jbrenner@taosinc.com,
amit.kucheria@verdurent.com, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 5/5] iio:light:tsl2563 move out of staging
Date: Sat, 26 Jan 2013 10:40:56 +0000 [thread overview]
Message-ID: <5103B2B8.2050901@kernel.org> (raw)
In-Reply-To: <50FC6592.6030005@kernel.org>
On 01/20/2013 09:45 PM, Jonathan Cameron wrote:
> On 01/20/2013 01:32 PM, Peter Meerwald wrote:
>> Hello,
>>
>>> This driver is simple, uses the latest interfaces and contains few if
>>> any controversial elements. All of its interfaces have been in place
>>> for a long time now. Hence let's move it out of staging.
>>
>> two small nitpicks inline
>>
> Thanks!
>> regards, p.
> ...
>>> obj-$(CONFIG_ADJD_S311) += adjd_s311.o
>>> obj-$(CONFIG_SENSORS_LM3533) += lm3533-als.o
>>> +obj-$(CONFIG_SENSORS_TSL2563) += tsl2563.o
>>
>> there is the SENSORS_ prefix which is an inconsistency; there were some
>> arguments against it...
> Hmm. I was holding off on this purely as it might break things. It's used in
> one of the omap board files for starters.
>
> Tony, what are your views on cleaning this up? It's in
> arch/arm/mach-omap2/board-rx51-peripherals.c.
> There presumably isn't really a problem in a patch fixing this end
> going via IIO and another to change the ifdef via your tree? At somepoint
> the support won't be enabled but it won't cause any problems.
>
> There is still a bit of debate on whether an IIO prefix makes sense
> or if such prefixes should be dropped entirely so we end up with
> CONFIG_TSL2563...
>
I've left this whole issue be for now so as to not hold up the rest of the
patch series.
Anyhow all added to togreg branch of iio.git
>
>>
>>> obj-$(CONFIG_VCNL4000) += vcnl4000.o
>>> obj-$(CONFIG_HID_SENSOR_ALS) += hid-sensor-als.o
>>> diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c
>>> new file mode 100644
>>> index 0000000..86bcadc
>>> --- /dev/null
>>> +++ b/drivers/iio/light/tsl2563.c
>>> @@ -0,0 +1,887 @@
>>> +/*
>>> + * drivers/i2c/chips/tsl2563.c
>>
>> this should be drivers/iio/light/tsl2563.c
>>
> Good spot, thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-01-26 10:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 10:35 [PATCH 0/5] iio:light:tsl2563 cleanup and move out of staging Jonathan Cameron
2013-01-12 10:35 ` [PATCH 1/5] staging:iio:light:tsl2563 drop unnecessary brackets around constants Jonathan Cameron
2013-01-12 10:35 ` [PATCH 2/5] staging:iio:light:tsl2563 clean comments up Jonathan Cameron
2013-01-12 10:35 ` [PATCH 3/5] staging:iio:tsl2563 Simplify exit path on error in read_interrupt_config Jonathan Cameron
2013-01-12 10:35 ` [PATCH 4/5] staging:iio:tsl2563 drop pointless forward declaration Jonathan Cameron
2013-01-12 10:35 ` [PATCH 5/5] iio:light:tsl2563 move out of staging Jonathan Cameron
2013-01-20 13:32 ` Peter Meerwald
2013-01-20 21:45 ` Jonathan Cameron
2013-01-26 10:40 ` Jonathan Cameron [this message]
2013-01-20 12:09 ` [PATCH 0/5] iio:light:tsl2563 cleanup and " Jonathan Cameron
2013-01-20 13:34 ` Peter Meerwald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5103B2B8.2050901@kernel.org \
--to=jic23@kernel.org \
--cc=amit.kucheria@verdurent.com \
--cc=jbrenner@taosinc.com \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).